Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Re enable worker #9221

Merged
merged 2 commits into from
Jun 4, 2017
Merged

Re enable worker #9221

merged 2 commits into from
Jun 4, 2017

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Jun 3, 2017

Fix #9222
Fix #7344

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
    • Test coverage already exists as several tests used to fail when worker is enabled for ledger.
  • Ran git rebase -i to squash commits (if needed).
    • Not needed
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:

See comment in #9222.

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

The actual update here wasn't needed but it makes it explicit what the fix was

Fix #9222
@bsclifton
Copy link
Member

Testing this on Windows... since it always works fine in dev mode, I'm packaging/building an installer

@bsclifton bsclifton self-requested a review June 4, 2017 17:01
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on a packaged Windows build with a fresh profile- wallet creation works great. ++ 😄

@bsclifton bsclifton merged commit bed842d into master Jun 4, 2017
@bsclifton bsclifton deleted the re-enable-worker branch June 4, 2017 17:53
bsclifton added a commit that referenced this pull request Jun 4, 2017
bsclifton added a commit that referenced this pull request Jun 4, 2017
@luixxiul
Copy link
Contributor

luixxiul commented Jun 5, 2017

Does this close #7344 because the 1st commit reverted another commit which has reverted something which had closed #7344?

@bsclifton
Copy link
Member

@luixxiul great catch- yes this does close #7344 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants