-
Notifications
You must be signed in to change notification settings - Fork 974
Ledger is broken (worker) #8884
Comments
didn't @bbondy fix this in muon? |
fyi I reverted commit that broke it and reopened #7344. Since ledger is working again I'm closing this one for now |
Let's keep this open so that we can track this problem |
which problem? ledger is working again and the fix that broke it was fot #7344. Please educate me if I'm wrong |
#7344 here the problem was only on windows and the problem was different than this one. What you reverted was just a switch for a worker, so this specific problem was not fixed. Problem that I experienced is happening on macOS and probably on all other platforms. That's why I will keep this one opened. |
Per issue description, there isn't a problem anymore. The issue is described as You can't create a wallet, which is now possible, and describes an error log that no longer exists. Could you update overall steps to reproduce to match it as a tracking issue, referencing what you gently described to me? Since we still want that feature and worker is failing only on linux/mac. This would make QA job easier. In fact, I was going to create an issue to track the revert but since you reopened it for the same reason, a new one would be a dupe 🙂 thanks |
I think this is fixed by @bbondy ? |
Fixed with #9221 |
Did you search for similar issues before submitting this one?
yes
Describe the issue you encountered:
You can't create a wallet
Platform (Win7, 8, 10? macOS? Linux distro?):
macOs
Brave Version (revision SHA):
99e8a2
Steps to reproduce:
Actual result:
Wallet is created
yes
no
yes
The text was updated successfully, but these errors were encountered: