Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Displays hide button in the ledger table #9145

Merged
merged 1 commit into from
May 30, 2017
Merged

Displays hide button in the ledger table #9145

merged 1 commit into from
May 30, 2017

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented May 30, 2017 •
edited by luixxiul
Loading

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Resolves #9137

Auditors: @mrose17 @luixxiul

Test Plan:

  • npm run add-simulated-synopsis-visits 100
  • click show all
  • hide button should be displayed at the bottom

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@NejcZdovc
Displays hide button in the ledger table
0fe0329 
Resolves brave#9137

Auditors: @mrose17 @luixxiul

Test Plan:
- add some sites to the ledger
- click show all
- hide button should be displayed at the bottom
@NejcZdovc NejcZdovc added this to the 0.18.x milestone May 30, 2017
@NejcZdovc NejcZdovc self-assigned this May 30, 2017
mrose17
mrose17 approved these changes May 30, 2017
View reviewed changes
Copy link
Member

@mrose17 mrose17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

luixxiul
luixxiul approved these changes May 30, 2017
View reviewed changes
Copy link
Contributor

@luixxiul luixxiul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test plan works.

@NejcZdovc NejcZdovc merged commit 033b122 into brave:master May 30, 2017
@luixxiul
Copy link
Contributor

This should have been merged to 0.18.x I'm afraid.

@luixxiul luixxiul mentioned this pull request May 30, 2017
Closed
@NejcZdovc
Copy link
Contributor Author

NejcZdovc commented May 30, 2017 •
edited
Loading

@luixxiul it is merged into 0.18.x

@luixxiul
Copy link
Contributor

Ah, right.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mrose17 mrose17 mrose17 approved these changes

@luixxiul luixxiul luixxiul approved these changes

Assignees

@NejcZdovc NejcZdovc

Labels
feature/rewards
Projects
None yet
Milestone
0.18.x Release
Development

Successfully merging this pull request may close these issues.
3 participants
@NejcZdovc @luixxiul @mrose17