Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Add "Hide Lower" button on Brave Payments #9137

Closed
luixxiul opened this issue May 30, 2017 · 2 comments
Closed

Add "Hide Lower" button on Brave Payments #9137

luixxiul opened this issue May 30, 2017 · 2 comments
Assignees
@NejcZdovc
Labels
feature/rewards QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.18.x Release

Comments

@luixxiul
Copy link
Contributor

luixxiul commented May 30, 2017 •
edited
Loading

Test plan

#9145

Describe the issue you encountered: Add "Hide 0% sites" button on Brave Payments.

#7347 (comment)

Once you push "Show all" button, there is no way of hiding 0% sites.

As a result of that:

alot

  • Brave Version (revision SHA): 0.15.310

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:

  • Any related issues:
@NejcZdovc NejcZdovc mentioned this issue May 30, 2017
Closed
@NejcZdovc NejcZdovc self-assigned this May 30, 2017
@NejcZdovc NejcZdovc added this to the 0.18.x milestone May 30, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue May 30, 2017
@NejcZdovc
Displayes hide button in the ledger table
90dba36 
Resolves brave#9137

Auditors: @mrose17 @luixxiul

Test Plan:
- add some sites to the ledger
- click show all
- hide button should be displayed at the bottom
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue May 30, 2017
@NejcZdovc
Displays hide button in the ledger table
0fe0329 
Resolves brave#9137

Auditors: @mrose17 @luixxiul

Test Plan:
- add some sites to the ledger
- click show all
- hide button should be displayed at the bottom
@NejcZdovc NejcZdovc mentioned this issue May 30, 2017
Merged
7 tasks
NejcZdovc added a commit that referenced this issue May 30, 2017
@NejcZdovc
Merge pull request #9145 from NejcZdovc/hotfix/#9137-show-all
033b122 
Displays hide button in the ledger table
This was referenced Jul 24, 2017
Closed
Closed
Closed
Closed
@luixxiul luixxiul mentioned this issue Jul 26, 2017
Closed
44 tasks
This was referenced Jul 26, 2017
Closed
Closed
@luixxiul luixxiul changed the title Add "Hide 0% sites" button on Brave Payments Add "Hide Lower" button on Brave Payments Jul 26, 2017
@luixxiul
Copy link
Contributor Author

The title of this issue was changed.

@luixxiul luixxiul mentioned this issue Jul 26, 2017
Closed
@luixxiul
Copy link
Contributor Author

Follow-up: #10158

@alexwykoff alexwykoff mentioned this issue Jul 27, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
feature/rewards QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.18.x Release
Development

No branches or pull requests
4 participants
@luixxiul @NejcZdovc @srirambv @LaurenWags