Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fix bookmark hanger dialog alignment bug #9041

Merged
merged 1 commit into from
May 29, 2017
Merged

Fix bookmark hanger dialog alignment bug #9041

merged 1 commit into from
May 29, 2017

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented May 25, 2017

Closes #9040
Follow-up to #8985 (comment)

Auditors:

Test Plan 1:

  1. Click the star icon on the URL bar
  2. Make sure the bookmark hanger appears under the star icon, not at the center of the browser window

Test Plan 2:

  1. "Add bookmark" on the bookmark toolbar
  2. Make sure the bookmark dialog appears at the center of the browser window

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

Closes #9040

Auditors:

Test Plan 1:
1. Click the star icon on the URL bar
2. Make sure the bookmark hanger appears under the star icon, not at the center of the browser window

Test Plan 2:
1. "Add bookmark" on the bookmark toolbar
2. Make sure the bookmark dialog appears at the center of the browser window
Copy link
Contributor

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@cezaraugusto cezaraugusto merged commit 82a4223 into brave:master May 29, 2017
@luixxiul luixxiul deleted the dialog-aphrodite branch June 2, 2017 04:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants