Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Refactor Dialog with Aphrodite #8985

Merged
merged 1 commit into from
May 22, 2017
Merged

Refactor Dialog with Aphrodite #8985

merged 1 commit into from
May 22, 2017

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented May 21, 2017

Closes #8984

Per 2dd92a9, dialog.less can be safely removed (as styles under 'menu' has been just copied).

Test Plan:

  1. Open 'Import Browser Data...' from Bookmarks on the main menu
  2. Open devtool
  3. Make sure 'dialog' is styled properly

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@@ -40,6 +43,7 @@ class Dialog extends ImmutableComponent {
render () {
return <div className={cx({
dialog: true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it needed somewhere? we are removing style class and I can't see any test using it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops I just forgot to check that out. I'm going to remove it, thanks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed with 3ba6110

}
}
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't get enough of less less :)

@cezaraugusto
Copy link
Contributor

I would recommend removing .dialog class since we're not using as far I can see. Other than that LGTM.

Closes #8984

Per 2dd92a9, dialog.less can be safely removed (as styles under 'menu' has been just copied).

Test Plan:
1. Open 'Import Browser Data...' from Bookmarks on the main menu
2. Open devtool
3. Make sure 'dialog' is styled properly
@luixxiul luixxiul merged commit 6be2b4b into brave:master May 22, 2017
@luixxiul
Copy link
Contributor Author

My bad, that conversion breaks the bookmarkHanger (which I often forget that it is also a component with Dialog). Fortunately the change is not available on 0.15.300 series, so I'm fixing it before 0.16.100. thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants