This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Remove duplicate inside coinbasePanel #8723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by introducing another function (coinbaseAvailability) Follow up to #8666 Auditors: Test Plan: 1. Open about:preferences#payments 2. Set the budget to 5 USD 3. Click "Add funds" 4. Make sure the button and the title is displayed on the 1st row 5. Set the budget to other than 5 USD 6. Click "Add funds" 7. Make sure 'coinbaseNotAvailable' is displayed
luixxiul
added
refactoring/aphrodite
polish
|
Merged... Manually tested and I'm sure this does not cause a regression. |
|
Shouldn't the text be left justified? |
|
I have discussed it with @cezaraugusto and concluded the done button should be there if coinbase logo is displayed. You can compare the placement on the pictures which I attached here: #8666 (comment) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by introducing another function (coinbaseAvailability)
Follow up to #8666 and #8042
Auditors:
Test Plan:
git rebase -ito squash commits (if needed).Test Plan: