Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Unify modal dialogs of payments and sync #8042

Closed
luixxiul opened this issue Apr 2, 2017 · 0 comments · Fixed by #8044
Closed

Unify modal dialogs of payments and sync #8042

luixxiul opened this issue Apr 2, 2017 · 0 comments · Fixed by #8044
Assignees
@luixxiul
Labels
feature/sync polish Nice to have — usually related to front-end/visual tasks. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified refactoring/aphrodite release-notes/include
Milestone
0.15.300 (Frozen,...

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Apr 2, 2017 •
edited
Loading

Test plan

  1. Refactor syncTab.js with Aphrodite #8044 (comment)
  2. Normalize modal overlay dialogs #8666 (comment)
  3. Remove duplicate inside coinbasePanel #8723 (comment)

Describe the issue you encountered: Unify modal dialogs of payments and sync. Example:

screenshot 2017-04-03 2 28 18

  • Platform (Win7, 8, 10? macOS? Linux distro?):

  • Brave Version (revision SHA): 0.14.1

  • Any related issues:
@luixxiul luixxiul added feature/sync polish Nice to have — usually related to front-end/visual tasks. labels Apr 2, 2017
@luixxiul luixxiul self-assigned this Apr 2, 2017
@luixxiul luixxiul mentioned this issue Apr 2, 2017
Merged
4 tasks
@luixxiul luixxiul added this to the 0.15.1 milestone Apr 25, 2017
This was referenced May 2, 2017
Closed
Closed
Closed
@luixxiul luixxiul mentioned this issue May 3, 2017
Merged
4 tasks
@luixxiul luixxiul mentioned this issue May 5, 2017
Merged
4 tasks
This was referenced May 5, 2017
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@luixxiul luixxiul

Labels
feature/sync polish Nice to have — usually related to front-end/visual tasks. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified refactoring/aphrodite release-notes/include
Projects
None yet
Milestone
0.15.300 (Frozen, only critical adds ...
Development

Successfully merging a pull request may close this issue.

Refactor syncTab.js with Aphrodite
3 participants
@alexwykoff @luixxiul @srirambv