Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

sync favicon #7295

Merged
merged 1 commit into from
Feb 18, 2017
Merged

sync favicon #7295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions js/state/syncUtil.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,6 +357,7 @@ module.exports.createSiteData = (site) => {
location: '',
title: '',
customTitle: '',
favicon: '',
lastAccessedTime: 0,
creationTime: 0
}
Expand Down
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
"preload-httpse": "node ./preload-httpse.js",
"start-log": "node ./tools/start.js --user-data-dir=brave-development --debug=5858 --enable-logging=stderr --v=1 --enable-extension-activity-logging --enable-sandbox-logging --enable-dcheck",
"start": "node ./tools/start.js --user-data-dir=brave-development --debug=5858 --enable-logging --v=0 --enable-extension-activity-logging --enable-sandbox-logging --enable-dcheck",
"start2": "node ./tools/start.js --user-data-dir=brave-development-2 --debug=5859 --enable-logging --v=0 --enable-extension-activity-logging --enable-sandbox-logging --enable-dcheck",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

start2

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i see, this is a feature 👍

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yah i figured it is useful to testers now that sync is merged

"start-brk": "node ./tools/start.js --debug-brk=5858 -enable-logging --v=0 --enable-dcheck",
"test": "cross-env NODE_ENV=test mocha --require babel-register --require babel-polyfill --recursive \"test/**/*Test.js\"",
"unittest": "cross-env NODE_ENV=test mocha --require babel-register --require babel-polyfill --recursive \"test/unit/**/*Test.js\"",
Expand Down
1 change: 1 addition & 0 deletions test/unit/state/syncUtilTest.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ describe('syncUtil', () => {
name: 'historySite',
objectId,
value: {
favicon: 'https://calendar.google.com/googlecalendar/images/favicon_v2014_18.ico',
location: 'https://calendar.google.com/calendar/render#main_7',
title: 'Google Calendar',
customTitle: '',
Expand Down