Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

sync favicon #7295

Merged
merged 1 commit into from
Feb 18, 2017
Merged

sync favicon #7295

merged 1 commit into from
Feb 18, 2017

Conversation

diracdeltas
Copy link
Member

Test Plan:

  1. npm start
  2. enable sync in pyramid 0
  3. npm run start2
  4. sync pyramid 1 to pyramid 0
  5. bookmark google.com in pyramid 0
  6. in pyramid 1, go to about:bookmarks. you should see the google favicon.

Fix #7294

ayumi
ayumi reviewed Feb 16, 2017
View reviewed changes
package.json
@@ -29,6 +29,7 @@
"preload-httpse": "node ./preload-httpse.js",
"start-log": "node ./tools/start.js --user-data-dir=brave-development --debug=5858 --enable-logging=stderr --v=1 --enable-extension-activity-logging --enable-sandbox-logging --enable-dcheck",
"start": "node ./tools/start.js --user-data-dir=brave-development --debug=5858 --enable-logging --v=0 --enable-extension-activity-logging --enable-sandbox-logging --enable-dcheck",
"start2": "node ./tools/start.js --user-data-dir=brave-development-2 --debug=5859 --enable-logging --v=0 --enable-extension-activity-logging --enable-sandbox-logging --enable-dcheck",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

start2

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i see, this is a feature 👍

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yah i figured it is useful to testers now that sync is merged

@diracdeltas diracdeltas added this to the 0.13.5 milestone Feb 16, 2017
@diracdeltas
re-add sync favicon
d8ae422 
also add start2 script for sync testing convenience
ayumi
ayumi approved these changes Feb 18, 2017
View reviewed changes
Copy link
Contributor

@ayumi ayumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
i'll make a new brave/sync release.

@ayumi ayumi merged commit e259d61 into master Feb 18, 2017
@ayumi ayumi deleted the fix/7294 branch February 18, 2017 02:12
@diracdeltas
Copy link
Member Author

thx

@srirambv srirambv mentioned this pull request Feb 22, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ayumi ayumi ayumi approved these changes

@srirambv srirambv Awaiting requested review from srirambv

Assignees
No one assigned
Labels
feature/sync misc/favicon
Projects
None yet
Milestone
0.13.5
Development

Successfully merging this pull request may close these issues.
3 participants
@diracdeltas @ayumi @luixxiul