Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Added needed cursor indicators requested in #5896 #5900

Closed
wants to merge 1 commit into from
Closed

Added needed cursor indicators requested in #5896 #5900

wants to merge 1 commit into from

Conversation

getsetbro
Copy link
Contributor

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Test Plan:

This CSS change resolves issue #5896 requested that the cursor indicate that items are clickable. The two items were the close icon and a SELECT element.

This CSS change solves issue #5896 requested that the cursor indicate that items are clickable. The two items were the close icon and a SELECT element.
@cndouglas
Copy link

#5896 was closed as invalid.

@bsclifton
Copy link
Member

@getsetbro apologies that I didn't comment here earlier ☹️

We want to keep the behavior of the default cursor, which gives a more app-like feel. However, we could update styles so that there is a hover effect. For the X, it should be @buttonColor when idle and #000 (black) when hovered. You can see a good example of this on the bookmarks manager, with the add folder or add bookmark icons

I'll close this PR... but if you were interested in adding the hover, you could create an issue and submit a new PR against it 😄

@bsclifton bsclifton closed this Nov 30, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants