This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Made every place of buttons on the navigation bar clickable #5750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dButton, stopButton, reloadButton and homeButton) clickable Fixes #5679 Auditors: @bradleyrichter Test Plan: 1. Enable Home Button 2. Open some pages in the same tab to enable backButton and forwardButton 3. Make sure every place of the buttons are clickable 4. Make sure height and width of the buttons remain the same (34x24, 26x24) 5. Make sure stopButton is centered
bsclifton
changed the title
4 tasks
|
Tried it out, looks (and works) great! Thanks, @luixxiul 😄 |
|
@bradleyrichter @bsclifton thanks for reviewing! |
|
@bradleyrichter I think the svg icons should be minified like before (unless it is not minified on building the binaries). |
4 tasks
This was referenced Dec 1, 2016
This was referenced Dec 11, 2016
This was referenced Dec 20, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bsclifton Can you pull this into master and get both @luixxiul and my changes?
Text from original PR by @luixxiul:
git rebase -ito squash commits (if needed).Made every place of buttons on the navigation bar (backButton, forwardButton, stopButton, reloadButton and homeButton) clickable.
The commit of this PR makes the all area inside the button clickable by removing the margin and padding around the icon, which has been only clickable, and setting the size of the svg icons with
background-size.Fixes #5679
Auditors: @bradleyrichter (Especially I'd love to hear your feedback on the sizes of the buttons. Please have a look at background-size properties, thanks.)
Test Plan:
Image 1
Image 2
Image 3
#5526