Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Remove hacks of the buttons on the navigation bar (for Windows) #5928

Closed
srirambv opened this issue Nov 30, 2016 · 5 comments
Closed

Remove hacks of the buttons on the navigation bar (for Windows) #5928

srirambv opened this issue Nov 30, 2016 · 5 comments
Labels
design A design change, especially one which needs input from the design team. feature/navbar QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Milestone
0.13.0

Comments

@srirambv
Copy link
Collaborator

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
URL bar issues on Chromium54 build(0.13.0 preview2)

Expected behavior:
Should align properly

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x64

  • Brave Version:
    0.13.0 Preview 2

  • Steps to reproduce:

    1. Reload button is not properly aligned
    2. Stop reload button is not properly aligned
    3. Bookmark icon is bottom aligned
    4. URL bar is not aligned with the bookmark icon
    5. Window buttons have extra padding on top when the browser is maximized

  • Screenshot if needed:
    image

    image

    ezgif com-video-to-gif

  • Any related issues:
    cc: @bsclifton @jkup @bradleyrichter
@srirambv srirambv added chromium54 design A design change, especially one which needs input from the design team. OS/Windows labels Nov 30, 2016
@srirambv srirambv added this to the 0.13.0 milestone Nov 30, 2016
@r3wt
Copy link

r3wt commented Dec 1, 2016

can repro in ubuntu 14.04, ubuntu 16.04, opensuse 42.2

screenshot_20161201_000331

@luixxiul
Copy link
Contributor

luixxiul commented Dec 1, 2016

@srirambv the windows specific styles in navigationBar.less causes the bug. I'm working on it.

@luixxiul
Copy link
Contributor

luixxiul commented Dec 1, 2016 •
edited
Loading

@r3wt Are you running 0.13.0 Preview2? I cannot reproduce it on Ubuntu 16.04 (Ubuntu Unity). I think the bug was fixed with #5739. Would you please check if it exists on openSUSE with the latest build?

@luixxiul
Copy link
Contributor

luixxiul commented Dec 1, 2016

@srirambv actually all of the hacks in https://github.com/brave/browser-laptop/blob/master/less/navigationBar.less#L39-L57 are no longer necessary thanks to #5739 and #5750 (#5737).

@luixxiul luixxiul mentioned this issue Dec 1, 2016
Merged
4 tasks
This was referenced Dec 20, 2016
Closed
Closed
Closed
Closed
Closed
@luixxiul
Copy link
Contributor

Test plan: #5967 (comment)

Also I added release-notes/exclude as the issue appeared and was fixed within the same milestone.

@luixxiul luixxiul changed the title URL bar issues on Chromium54 build(0.13.0 preview2) Removed the hacks of the buttons on the navigation bar (for Windows) Jan 22, 2017
@luixxiul luixxiul changed the title Removed the hacks of the buttons on the navigation bar (for Windows) Remove hacks of the buttons on the navigation bar (for Windows) Jan 22, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
design A design change, especially one which needs input from the design team. feature/navbar QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.13.0
Development

No branches or pull requests
3 participants
@luixxiul @r3wt @srirambv