This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
New tab button can now show a dropdown #5696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sButton Fixes #1594 Auditors: @lucidNTR, @cezaraugusto, @jkup Test Plan: 1. Launch Brave and right click the new tab button "+" 2. Verify that it shows New Private / New Session / New Window 3. Cancel the menu and then click and hold the new tab button "+" 4. After ~300ms, the menu should show up 5. Cancel the menu again and navigate to Brave.com. 6. Follow a few links so that you have a history, then hit back button. 7. Confirm you can right click both the back/forward buttons to show the menu 8. Cancel the menu and then click and hold each button to confirm the existing behavior works
|
@lucidNTR sorry it took us so long to get to this! I love it though ❤️ Huge thanks for knocking this out (your commit is still intact, I just had to tweak a few things 😄 ) |
3 tasks
|
great add, thanks! One suggestion would be to have New tab option there too. Kind of like how the primary action of the back button is also shown in the back list. Will still merge though now. |
This was referenced Nov 21, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits (if needed).Fixes #4398
Fixes #1594
Auditors: @lucidNTR, @cezaraugusto, @jkup
This PR was originally by @lucidNTR; I adjusted a few things and then also added right click as a way to trigger the long press button. I went ahead and added webdriver tests for this functionality too.
screenshot
Here's what the new menu looks like (you can click and hold on the + or right click it)
Because the right-click change was made to the LongPressButton control, the back and forward buttons get this change for free (they were already triggerable by click and hold):
test plan