Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Added safe wrapper for toLocateDate() to handle null/invalid dates an… #5621

Merged
merged 1 commit into from
Nov 15, 2016
Merged

Added safe wrapper for toLocateDate() to handle null/invalid dates an… #5621

merged 1 commit into from
Nov 15, 2016

Conversation

bsclifton
Copy link
Member

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

@bbondy: ** Would be great if this could make it into 0.12.9, but can be pushed to 0.12.10. I'll tentatively mark it as 0.12.9 and let you choose while merging** 😄

…d updated code on Bookmark Manager.

Fixes #5576

Auditors: @bbondy

Test Plan:

  1. Launch Brave and open Bookmarks Manager
  2. Click the import button and import a file as html
  3. View the bookmarks in bookmarks manager. Notice the date is now empty (and not the epoch)

…d updated code on Bookmark Manager.

Fixes #5576

Auditors: @bbondy

Test Plan:
1. Launch Brave and open Bookmarks Manager
2. Click the import button and import a file as html
3. View the bookmarks in bookmarks manager. Notice the date is now empty (and not the epoch)
@bsclifton
Copy link
Member Author

Here's what the bug looks like:
image

And here's what the fix looks like:
screen shot 2016-11-14 at 3 15 02 pm

@bsclifton
Copy link
Member Author

Moving to 0.12.10

@bsclifton bsclifton modified the milestones: 0.12.10 release , 0.12.9dev Nov 15, 2016
@bbondy
Copy link
Member

bbondy commented Nov 15, 2016

++

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants