Commits on Nov 14, 2016

1. The big history-fixer-upper …

   - History code was refactored
     - one step forward with regard to #3502
     - session helper created for aboutHistory (tests added)
     - history specific methods broke out into historyUtil (tests added)
     - history stores it's data in AppStore.about.history (similar structure to new tab code)
   
   - about:history is only updated when something changed
     - # calls to render on about:history is drastically reduced (should fix #5382; please reopen if not)
   
   - about:brave text update
   Implements followup feedback for #5436 (comment)
   
   Auditors: @cezaraugusto, @darkdh
   
   Test Plan:
   1. Launch Brave and go to about:history
   2. With history open, open a new tab and visit a site you have never been to before (hint: just append #1234567 to the end of URL)
   3. Switch back to history tab and confirm entry shows
   4. Open another new tab; in the URL bar, type an entry for a site you HAVE been to before (which shows in the autocomplete)
   5. Instead of hitting enter, pick the URL from the autocomplete drop down (use arrow keys and press enter,  OR  click)
   6. Visit about:history again and confirm this entry shows
   7. On about:history, click some of the entries. They should show their selection status in a faster manner than before
   
   Advanced test notes:
   - After exiting Brave, you can view the session file to confirm the details used in about:history and about:brave are removed and NOT stored to disk
   
   -----
   
   Remove unnecessary/broken/useless context menu items for about pages
   
   Fixes #4812
   
   -----
   
   Update icon for about pages to fa-list (except for about:newtab)
   
   Fixes #5497
   
   Auditors: @bradleyrichter
   
   Test Plan:
   1. Launch Brave and visit about:about
   2. Open each of the links and confirm it's the `fa-list` icon

   

   bsclifton committed Nov 14, 2016
   Configuration menu

   • View commit details
   • Copy full SHA for 4ddf839
   • Browse repository at this point

   Copy the full SHA

   4ddf839 View commit details

   Browse the repository at this point in the history