This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
History fixes and misc about page fixes #5600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- History code was refactored - one step forward with regard to #3502 - session helper created for aboutHistory (tests added) - history specific methods broke out into historyUtil (tests added) - history stores it's data in AppStore.about.history (similar structure to new tab code) - about:history is only updated when something changed - # calls to render on about:history is drastically reduced (should fix #5382; please reopen if not) - about:brave text update Implements followup feedback for #5436 (comment) Auditors: @cezaraugusto, @darkdh Test Plan: 1. Launch Brave and go to about:history 2. With history open, open a new tab and visit a site you have never been to before (hint: just append #1234567 to the end of URL) 3. Switch back to history tab and confirm entry shows 4. Open another new tab; in the URL bar, type an entry for a site you HAVE been to before (which shows in the autocomplete) 5. Instead of hitting enter, pick the URL from the autocomplete drop down (use arrow keys and press enter, OR click) 6. Visit about:history again and confirm this entry shows 7. On about:history, click some of the entries. They should show their selection status in a faster manner than before Advanced test notes: - After exiting Brave, you can view the session file to confirm the details used in about:history and about:brave are removed and NOT stored to disk ----- Remove unnecessary/broken/useless context menu items for about pages Fixes #4812 ----- Update icon for about pages to fa-list (except for about:newtab) Fixes #5497 Auditors: @bradleyrichter Test Plan: 1. Launch Brave and visit about:about 2. Open each of the links and confirm it's the `fa-list` icon
|
Comment per @bradleyrichter in last thread:
(I'll look at fixing that up 😄 ) |
bsclifton
commented
Nov 14, 2016
| sites = makeImmutable(sites) || new Immutable.List() | ||
| return sites.filter((site) => siteUtil.isHistoryEntry(site)) | ||
| .sort(sortTimeDescending) | ||
| .slice(0, aboutHistoryMaxEntries) |
There was a problem hiding this comment.
note: fix from a9c3304 was kept here when rebasing 😄
bsclifton
commented
Nov 14, 2016
| assert.deepEqual(result.toJS(), expectedResult) | ||
| }) | ||
| it('only returns `historyUtil.maxEntries` results', function () { | ||
| let tooManyEntries = new Immutable.List().push(historyDayOne) |
There was a problem hiding this comment.
note to self: this needs to check the order they're in
This was referenced Nov 14, 2016
|
I think it looks good. I also asked @darkdh to take a look and those can be done in followups if he has comments. |
|
lgtm, ++ |
This was referenced Nov 21, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits (if needed).redo of #5559
NOTE: I thought I had fixed the history issues with this, but I was wrong. I removed the issues I thought I had fixed from this PR
History code was refactored
about:history is only updated when something changed
about:brave text update
Implements followup feedback for Add basic styles to about:about and created page w/ version information (about:brave) #5436 (comment)
Auditors: @cezaraugusto, @darkdh, @bbondy
Remove unnecessary/broken/useless context menu items for about pages
Fixes #4812
Update icon for about pages to fa-list (except for about:newtab)
Fixes #5497
Auditors: @bradleyrichter
Test Plan:
fa-listiconScreenshots
Here's one showing: