This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Improved errors when loading ledger balance #5496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbondy
reviewed
Nov 9, 2016
| @@ -26,7 +26,7 @@ paymentsSidebarText2=All transaction IP addresses are anonymized with technology | |||
| paymentsSidebarText3=Brave Bitcoin Wallets are provided through a partnership with: | |||
| paymentsSidebarText4=Your contributions in the form of credit cards and bank cards are handled by: | |||
| accountBalance=account balance | |||
| accountBalanceConnectionError=error, can't retrieve data | |||
There was a problem hiding this comment.
For l10n updates pls only update en-US the other files will be pulled down from transifex.
There was a problem hiding this comment.
Thanks! updated the PR.
Humanizes errors when loading ledger balance by mapping error codes to localized messages. Fix #4920 Auditors: @luixxiul Test Plan: 1. Disable internet for Brave (can disable system wide, or app specific eg w/ Little Snitch). 2. Open Brave and view Preferences > Payments. 3. Account balance should show error and details.
ayumi
force-pushed
the
feature/better-ledger-balance-errors
branch
from
dfb509b
to
e81aa58
Compare
|
lgtm but I didn't test, @luixxiul would you mind? Thanks. |
|
It's on master now, and will be in the 0.12.9 preview build. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Humanizes errors when loading ledger balance by mapping error codes to localized messages.
Fix #4920
Auditors: @luixxiul
Test Plan: