This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Bookmark multi-select #5056
Merged
Bookmark multi-select #5056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates required to sortableTable in order to support multi-drag - sortableTable selection is now state based (no longer queries DOM) - code was refactored (logic should be exactly the same) to support being state based - if multiple items are selected, a different drag handler is applied (so all rows can be sent, not just one) - if multiple items are selected and there is a drag handler, a dragImage (stack of papers) will be applied on cursor With regards to about:bookmarks: - Existing about:history functionality (including multiple table selection) works great - about:bookmarks now handle multi-select (for context menus). You can delete multiple entries, etc - You can select and move multiple items within the same folder OR into a new folder Fixes #1005 Auditors: @darkdh, @bbondy
4 tasks
darkdh
reviewed
Oct 23, 2016
| onClick (e) { | ||
| /** | ||
| * If you want multi-select to span multiple tables, you can | ||
| * provide a single React.Component as the state owner. |
There was a problem hiding this comment.
Maybe also specify state owner must possesses state.selection property
|
lgtm |
bbondy
reviewed
Oct 24, 2016
| @@ -31,7 +34,7 @@ class DeleteHistoryEntryButton extends ImmutableComponent { | |||
| if (e && e.preventDefault) { | |||
| e.preventDefault() | |||
| } | |||
| // BSCTODO: ... | |||
| // BSCTODO: delete the selected entry | |||
There was a problem hiding this comment.
todo format is TODO(bsclifton): delete the selected entry
|
++ :D |
This was referenced Oct 26, 2016
This was referenced Oct 27, 2016
This was referenced Oct 28, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits (if needed).Updates required to sortableTable in order to support multi-drag
Updated functionality on about:bookmarks:
Fixes #1005
Includes follow up of feedback for
#4834 (review)
#4488 (review)
Auditors
@darkdh, @bbondy
Screenshots
cc @bradleyrichter
multiple selection
multiple items dragged (notice cursor)
context menu for multiple selected items (ex: delete all selected)
