Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

about:history enhancements #4488

Merged
merged 2 commits into from
Oct 4, 2016
Merged

about:history enhancements #4488

merged 2 commits into from
Oct 4, 2016

Conversation

bsclifton
Copy link
Member

@bsclifton bsclifton commented Oct 4, 2016

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • styles closer match the mockup; NOTE: style updates are to sortableTable (this may affect search engine page and payments page)
  • text no longer wraps; properly handles overflow
  • updated search box
  • sortable table now accepts a column type of "cell", allowing for custom controls to be passed rather than html
  • delete buttons are stubbed out, ready to be implemented
  • will be implementing multi-select soon

Fixes #4072
Fixes #3996

Introduces tests for about:history

Auditors: @bradleyrichter @bbondy

Screenshot:
screen shot 2016-10-03 at 8 59 10 pm

- styles closer match the mockup; NOTE: style updates are to sortableTable
- text no longer wraps; properly handles overflow
- updated search box
- sortable table now accepts a column type of "cell", allowing for custom controls to be passed rather than html
- delete buttons are stubbed out, ready to be implemented
- will be implementing multi-select soon

Fixes #4072
Fixes #3996

Introduces tests for about:history
@bsclifton bsclifton added this to the 0.12.4dev milestone Oct 4, 2016
if (e && e.preventDefault) {
e.preventDefault()
}
// BSCTODO: ...
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

@bbondy
Copy link
Member

bbondy commented Oct 4, 2016

++, just maybe flesh out the TODO more.
Great testss

@bbondy bbondy merged commit 49de1b4 into brave:master Oct 4, 2016
@luixxiul
Copy link
Contributor

luixxiul commented Oct 4, 2016

The table onabout:preferences#search was styled too, which was intended?

@bsclifton
Copy link
Member Author

bsclifton commented Oct 4, 2016

@luixxiul good catch- yes, it was intended... but unfortunately I didn't put a fix in for the headers.
Captured this with issue #4493

@bradleyrichter
Copy link
Contributor

time column should be fixed width, with no wrap:

image

@bradleyrichter
Copy link
Contributor

bradleyrichter commented Oct 4, 2016

column headers should be forced to vert-align center

image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refine styles in about:history to look more like mockup History entries are not properly aligned
7 participants