This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Revert "updateledgerinfo refactor" #3471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@diracdeltas sorry for merging this too early, I saw a positive agreeing comment on the last PR that @mrose17 left, but not a full approval, so I thought it would be a net good to merge into beta5, but apparently not. Reverting. |
|
np, this isn't really a necessary change except for the part that @mrose17 fixed, though the refactor is nice to have. |
|
let me suggest we wait until after the next beta is out and we can test it against master. i'd like to reduce a few moving parts here... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #3430