updateledgerinfo refactor

[diracdeltas]

• Submitted a ticket for my issue if one did not already exist.
• Used Github auto-closing keywords in the commit message.
• Ran git rebase -i to squash commits if needed.

consolidates calls for updating ledger info appstate, so it is less likely that ledgerInfo in appState will get out of sync with ledgerInfo in ledger.js

auditors: @mrose17

[diracdeltas]

@mrose17 says this was here because:

until client is defined, there isn’t any ledgerInfo so, yes, all the fields will be undefined.

however, as of https://github.com/brave/browser-laptop/pull/3432/files#diff-9b959b675446ba95e1abe0b81e0f7a9bR133, ledgerInfo does in fact have the creating property before client is created.

therefore i think this line above should be removed. if any calls to updateLedgerInfo require existence of client, they should do that check before calling updateLedgerInfo.

[mrose17]

sure!

[bbondy]

Merging for beat5, @mrose17 please audit afterwards.

[mrose17]

@bbondy - i wouldn't merge this. i don't think that @diracdeltas is done with it yet. it's also possible that other merges may have OBE'd this...

[bbondy]

was reverted here:
5e5c862

Please re-issue PR when ready Yan, sorry about that.