Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fix extension browser action webview displaying no content when first opened #14788

Merged
merged 1 commit into from
Jul 23, 2018

Conversation

petemill
Copy link
Member

@petemill petemill commented Jul 20, 2018

Fix #13633 via a workaround to hide and show the webview after the first time it is attached to a new WebContents.
Also avoid flash of different sizes by only setting a new size once the page has finished load (success or fail).

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

bridiver
bridiver previously approved these changes Jul 20, 2018
… opened

Fix #13633 via a workaround to hide and show the webview after the first time it is attached to a new WebContents.
Also avoid flash of different sizes by only setting a new size once the page has finished load (success or fail).
@petemill petemill force-pushed the fix/13633-extension-popup-blank branch from 12a82dd to 126f369 Compare July 20, 2018 19:20
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with both bitwarden and lastpass- works great 😄

Did you want to capture specific test steps and link to them in the issue? (then you can label w/ the release notes include / test steps included)

@bsclifton bsclifton merged commit e23baf9 into master Jul 23, 2018
@bsclifton bsclifton deleted the fix/13633-extension-popup-blank branch July 23, 2018 16:58
bsclifton added a commit that referenced this pull request Jul 23, 2018
Fix extension browser action webview displaying no content when first opened
@bsclifton
Copy link
Member

master e23baf9
0.24.x 0e1aa80
0.23.x e1944b3

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants