Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

MetaMask 4.6.1 Popup Can't Load #14122

Closed
jonathansampson opened this issue May 14, 2018 · 9 comments
Closed

MetaMask 4.6.1 Popup Can't Load #14122

jonathansampson opened this issue May 14, 2018 · 9 comments
Labels
bug duplicate Issue has already been reported feature/extensions priority/P3 Major loss of function.

Comments

@jonathansampson
Copy link
Collaborator

jonathansampson commented May 14, 2018

Description

The MetaMask 4.6.1 popup cannot finish loading. It appears to be stuck in some type of loop, which pertains to the popup window size.

metamask-bug

Steps to Reproduce

  1. Load MetaMask 4.6.1
  2. Click the extension's browser button

Actual result:
Popup is unusable.

Expected result:
Usable popup is presented.

Reproduces how often:
Always

Brave Version

0.22.711

about:brave info:

Brave: 0.22.711 
V8: 6.6.346.26 
rev: 31d6bccb220485dc44f0ce0c65ed797f0160c8a7 
Muon: 6.0.9 
OS Release: 10.0.17134 
Update Channel: Release 
OS Architecture: x64 
OS Platform: Microsoft Windows 
Node.js: 7.9.0 
Brave Sync: v1.4.2 
libchromiumcontent: 66.0.3359.139

Reproducible on current live release:
N/A

Additional Information

MetaMask 4.3 did not have this issue.

@jonathansampson
Copy link
Collaborator Author

From another channel, the issue is reportedly caused by a #8326. The MetaMask team is going to add a feature-test to ensure this API exists before making a call. That being said, we should explore implementation sooner rather than later.

@kjozwiak
Copy link
Member

kjozwiak commented May 18, 2018

+1 from the community.

However, the user has ran into the above issue on MM 4.3.0 and not 4.6.1.

@jonathansampson
Copy link
Collaborator Author

+1 from another user of 4.3.0.

@eljuno
Copy link
Contributor

eljuno commented Jun 5, 2018

+1 from Twitter with version 4.3.0 https://twitter.com/EkpedemeJohn/status/1003985607599775744

@euricsanti
Copy link

I am experiencing it myself. Even reinstalled Brave but nothing happened. Version 4.3.0 but, can't find how to upgrade the version. It happened that on Web3 websited did loaded the address as locked. Hopefully it can be fixed. Is a bummer.

Just letting know that this happened to me.

@jonathansampson
Copy link
Collaborator Author

The issue here is with the chrome.i18n.getAcceptLanguages method. If this method is called without evaluating chrome.runtime.lastError in the callback, an exception will be thrown. The exception causes the flickering.

We're working on a solution :)

@GeetaSarvadnya
Copy link
Collaborator

GeetaSarvadnya commented Jun 7, 2018

Steps to reproduce:

  1. Enable MetaMask extension 4.3.0
  2. Click on Metamask icon
  3. Open about:brave page
  4. Click on hamburger icons 2 - 3 times

Actual: Pop up is shaking and its not stable.
metamask issue

@eljuno
Copy link
Contributor

eljuno commented Jul 1, 2018

@bsclifton
Copy link
Member

Fixed with #14788

Closing as a duplicate of #13633

@bsclifton bsclifton added the duplicate Issue has already been reported label Jul 23, 2018
@bsclifton bsclifton removed this from the Backlog (Prioritized) milestone Jul 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug duplicate Issue has already been reported feature/extensions priority/P3 Major loss of function.
Projects
None yet
Development

No branches or pull requests

7 participants