Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Adds logic for 90% contribution amount #14324

Merged
merged 1 commit into from
Jun 4, 2018

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Jun 4, 2018

Resolves #14319

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

  • enable payments
  • add 90% - 99% BAT of your monthly budget to your wallet
  • make sure that you don't see insufficient notification
  • make contribution
  • when contribution is done click on payment history icon
  • make sure that you see correct amount on the history list (not monthly budget, but actual BAT)
  • click on the PDF
  • make sure that total is again actual BAT
  • sum BAT amounts in the table and make sure that total is correct

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@NejcZdovc NejcZdovc added this to the 0.23.x (Developer Channel) milestone Jun 4, 2018
@NejcZdovc NejcZdovc self-assigned this Jun 4, 2018
@NejcZdovc NejcZdovc requested review from ryanml and jasonrsadler June 4, 2018 06:37
Copy link
Contributor

@jasonrsadler jasonrsadler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ Code works great 🏆

@NejcZdovc NejcZdovc merged commit 423d50d into brave:master Jun 4, 2018
@NejcZdovc
Copy link
Contributor Author

NejcZdovc commented Jun 4, 2018

master 423d50d
0.23 9ed7cd1

NejcZdovc added a commit that referenced this pull request Jun 4, 2018
Adds logic for 90% contribution amount
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants