Contribution statement value differs from actual contribution amount

[evq]

Description

When you make a contribution with an amount different than your monthly budget the corresponding statement reports shows the month budget amount rather than the amount you actually transferred.

This difference happens when you don't have enough balance to cover your entire budget, there is logic server side to allow payments to go through with 90% of the necessary balance. In this case the browser receives an unsigned transaction for the current wallet balance rather than the desired monthly budget. It sounds like we probably don't make use of the amount in the unsigned transaction currently and always just use the monthly budget during statement generation?

First reported by @BobT36 on another issue - #13156 (comment)

Steps to Reproduce

1. Create a new wallet
2. Fill the wallet with 47.5 BAT
3. Set budget to 50 BAT
4. Have the contribution go through and check the resulting statement

Actual result:

Amount contributed shows 50 BAT

Expected result:
Amount contributed shows 47.5 BAT

Reproduces how often:

Brave Version

about:brave info:

Reproducible on current live release:

Additional Information

[BobT36]

Brave: 0.22.721
V8: 6.6.346.32
rev: bfe7cdd
Muon: 6.0.12
OS Release: 6.1.7601
Update Channel: Release
OS Architecture: x64
OS Platform: Microsoft Windows
Node.js: 7.9.0
Brave Sync: v1.4.2
libchromiumcontent: 66.0.3359.170

Brave_Payments_2018-05-31.pdf
See above for receipt.

[GeetaSarvadnya]

@evq @NejcZdovc Total contribution value is more than the contribution value

[evq]

I think the issue of the sum in the statement not adding up to the correct sum is different from the original issue. We should open a new issue - however I think this is super low priority

[srirambv]

sounds good.

[GeetaSarvadnya]

Verified on Windows 10 x64

• 0.23.11 6565c06
• Muon 7.1.0
• libchromiumcontent 67.0.3396.87

Verified on macOS 10.13.4 x64 using the following build:

• 0.23.11 6565c06
• muon: 7.1.0
• libchromiumcontent: 67.0.3396.87

Verified on Ubuntu 18.04 x64 using the following build:

• 0.23.17 bc754eb
• muon: 7.1.2
• libchromiumcontent: 67.0.3396.87