Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

set reloadMatchingUrl to true for URLs ending in a hash #14232

Merged
merged 1 commit into from
May 24, 2018
Merged

Conversation

diracdeltas
Copy link
Member

@diracdeltas diracdeltas commented May 24, 2018

fix #14231 (workaround)

Test Plan:

  1. go to a secure URL ending in a hash such as https://github.com/brave/browser-laptop/wiki/Fingerprinting-Protection-Mode#technical-details
  2. toggle shields or click 'reload' in the shields menu
  3. the page should appear as still secure instead of changing to insecure

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

fix #14231 (workaround)

Test Plan:
1. go to a secure URL ending in a hash such as https://github.com/brave/browser-laptop/wiki/Fingerprinting-Protection-Mode#technical-details
2. toggle shields or click 'reload' in the shields menu
3. the page should appear as still secure instead of changing to insecure
@diracdeltas diracdeltas requested review from bsclifton and darkdh May 24, 2018 07:11
@diracdeltas diracdeltas self-assigned this May 24, 2018
@diracdeltas diracdeltas added this to the 0.22.x Release 4 (Beta channel) milestone May 24, 2018
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on a few different sites and confirmed fix works great! 😄 👍

@bsclifton bsclifton merged commit 57c7b26 into master May 24, 2018
@bsclifton bsclifton deleted the fix/14231 branch May 24, 2018 07:42
bsclifton added a commit that referenced this pull request May 24, 2018
set reloadMatchingUrl to true for URLs ending in a hash
bsclifton added a commit that referenced this pull request May 24, 2018
set reloadMatchingUrl to true for URLs ending in a hash
@bsclifton
Copy link
Member

master 57c7b26
0.23.x 0e7a6c5
0.22.x bdb978a

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Toggling shields breaks the security indicator on URLs with hash
2 participants