Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Toggling shields breaks the security indicator on URLs with hash #14231

Closed
garrettr opened this issue May 24, 2018 · 1 comment · Fixed by #14232
Closed

Toggling shields breaks the security indicator on URLs with hash #14231

garrettr opened this issue May 24, 2018 · 1 comment · Fixed by #14232
Assignees
@diracdeltas
Labels
QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release/blocking release-notes/include security
Milestone
0.22.x Release 4 ...

Comments

@garrettr
Copy link

garrettr commented May 24, 2018 •
edited by bsclifton
Loading

Test plan

See #14232

Original issue description

Description

The security indicator in the address bar is sometimes incorrect for https://mail.google.com while the user is logged in. The icon should be a gray closed lock, indicating a secure connection, but sometimes it is a red open lock. Toggling shields on or off reliably causes the incorrect red open lock icon to be shown.

Steps to Reproduce

  1. Log in to Gmail (https://mail.google.com) in Brave
  2. Observe the (correct) gray closed lock icon for the secure origin
  3. Toggle shields
  4. Observe the (incorrect) red open lock icon for the secure origin

screen shot 2018-05-23 at 11 09 01 pm

Reproduces how often: 100%

Brave Version

Name Version
Brave 0.22.714
V8 6.6.346.26
rev fa2fbca
Muon 6.0.9
OS Release 17.5.0
Update Channel Release
OS Architecture x64
OS Platform macOS
Node.js 7.9.0
Brave Sync v1.4.2
libchromiumcontent 66.0.3359.139

Reproducible on current live release: Yes

Additional Information

Originally reported on Twitter.
@diracdeltas diracdeltas added this to the 0.22.x Release 4 (Beta channel) milestone May 24, 2018
@diracdeltas diracdeltas self-assigned this May 24, 2018
diracdeltas added a commit that referenced this issue May 24, 2018
@diracdeltas
set reloadMatchingUrl to true for URLs ending in a hash
ec1c2c3 
fix #14231 (workaround)

Test Plan:
1. go to a secure URL ending in a hash such as https://github.com/brave/browser-laptop/wiki/Fingerprinting-Protection-Mode#technical-details
2. toggle shields or click 'reload' in the shields menu
3. the page should appear as still secure instead of changing to insecure
@diracdeltas diracdeltas mentioned this issue May 24, 2018
Merged
10 tasks
@bsclifton bsclifton changed the title Toggling shields breaks the security indicator on Gmail Toggling shields breaks the security indicator on URLs with hash May 24, 2018
@btlechowski
Copy link
Contributor

btlechowski commented May 24, 2018 •
edited by LaurenWags
Loading

Verified on Ubuntu 17.10 x64

  • 0.22.721 bfe7cdd
  • muon 6.0.12
  • libchromiumcontent 66.0.3359.170

Verified on Windows 7 x64

  • 0.22.721 bfe7cdd
  • muon 6.0.12
  • libchromiumcontent 66.0.3359.170

Verified on Windows 10 x64 with:

  • 0.22.721 bfe7cdd
  • muon 6.0.12
  • libchromiumcontent 66.0.3359.170

Verified with macOS 10.12.6 using

  • 0.22.721 bfe7cdd
  • muon 6.0.12
  • libchromiumcontent 66.0.3359.170

@kjozwiak kjozwiak mentioned this issue May 24, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@diracdeltas diracdeltas

Labels
QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release/blocking release-notes/include security
Projects
None yet
Milestone
0.22.x Release 4 (Release channel)
Development

Successfully merging a pull request may close this issue.

set reloadMatchingUrl to true for URLs ending in a hash brave/browser-laptop
6 participants
@garrettr @diracdeltas @bsclifton @NejcZdovc @LaurenWags @btlechowski