This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Fixes invalid url error #13722
Merged
Fixes invalid url error #13722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #13722 +/- ##
==========================================
- Coverage 56.52% 56.52% -0.01%
==========================================
Files 283 283
Lines 28817 28819 +2
Branches 4777 4778 +1
==========================================
Hits 16289 16289
- Misses 12528 12530 +2
|
diracdeltas
reviewed
Apr 9, 2018
js/lib/request.js
Outdated
| @@ -49,8 +49,15 @@ module.exports.request = (options, callback) => { | |||
| }) | |||
| } | |||
|
|
|||
| let urlParsed = null | |||
| try { | |||
| urlParsed = urlParse(options.url) | |||
There was a problem hiding this comment.
are you sure this fixes the crash? muon.url.parse doesn't throw an error for most invalid URLs:
if the crash is because the URL is undefined, you could just replace this check with if (typeof options.url !== 'string') { return callback(new Error('URL is not valid')) }. then we wouldn't need to do url.parse on the URL unless we are in development mode (https://github.com/brave/browser-laptop/pull/13722/files#diff-2565914e73f517d565765ef02f30d306R59)
|
@diracdeltas can you please re-review |
NejcZdovc
force-pushed
the
fix/#12826-url
branch
from
8e805f9 to
5b9989c
Compare
Resolves brave#12826 Auditors: Test Plan:
NejcZdovc
force-pushed
the
fix/#12826-url
branch
from
5b9989c to
4a7908f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #12826
Submitter Checklist:
git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
Tests