Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

JS Error in Ledger code #12826

Closed
bridiver opened this issue Jan 24, 2018 · 0 comments
Closed

JS Error in Ledger code #12826

bridiver opened this issue Jan 24, 2018 · 0 comments
Assignees
@NejcZdovc
Labels
crash feature/rewards QA/no-qa-needed release-notes/exclude
Milestone
0.22.x Release 3 ...

Comments

@bridiver
Copy link
Collaborator

Description

Error: invalid url parameter at Object.module.exports.request (/Applications/Brave.app/Contents/Resources/app.asar/js/lib/request.js:41:29) at roundtrip (/Applications/Brave.app/Contents/Resources/app.asar/app/browser/api/ledger.js:1302:11) at request.request (/Applications/Brave.app/Contents/Resources/app.asar/app/browser/api/ledger.js:1321:16) at Function.defaultSession.webRequest.fetch (/Applications/Brave.app/Contents/Resources/app.asar/js/lib/request.js:55:5)

Found in several crash reports (ex: https://stats.brave.com/dashboard#crash/5a68a022836579001fd85b25)

Steps to Reproduce

Unknown STR

Actual result:
Error/Possible crash

Expected result:

Reproduces how often:
Unknown

Brave Version

0.19.141

Reproducible on current live release:
@NejcZdovc NejcZdovc self-assigned this Mar 12, 2018
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Apr 4, 2018
@NejcZdovc
Fixes invalid url error
8e805f9 
Resolves brave#12826

Auditors:

Test Plan:
@NejcZdovc NejcZdovc mentioned this issue Apr 4, 2018
Merged
10 tasks
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Apr 16, 2018
@NejcZdovc
Fixes invalid url error
5b9989c 
Resolves brave#12826

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Apr 16, 2018
@NejcZdovc
Fixes invalid url error
4a7908f 
Resolves brave#12826

Auditors:

Test Plan:
NejcZdovc added a commit that referenced this issue Apr 18, 2018
@NejcZdovc
Merge pull request #13722 from NejcZdovc/fix/#12826-url
1ec3da9 
Fixes invalid url error
NejcZdovc added a commit that referenced this issue Apr 18, 2018
@NejcZdovc
Merge pull request #13722 from NejcZdovc/fix/#12826-url
a268969 
Fixes invalid url error
NejcZdovc added a commit that referenced this issue Apr 18, 2018
@NejcZdovc
Merge pull request #13722 from NejcZdovc/fix/#12826-url
593cae3 
Fixes invalid url error
@NejcZdovc NejcZdovc added this to the 0.22.x Release 3 (Beta channel) milestone Apr 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
crash feature/rewards QA/no-qa-needed release-notes/exclude
Projects
None yet
Milestone
0.22.x Release 3 (Release Channel)
Development

No branches or pull requests
3 participants
@bridiver @NejcZdovc @srirambv