This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Fixes issue #12918, hides empty ad container on www.yahoo.com #12964
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12918
This is a pretty straightforward fix, the container for the yahoo billboard ad is identifiable by the element Id Billboard-ad. This adds that container to removeEmptyElements.css, as well as adds www.yahoo.com to the sites that removeEmptyElements.css is loaded on.
I did make a slight stylistic change, I broke out the sites inside the matches[] array on to a new line, as it was getting pretty lengthy on one line (it's presumably going to get longer). Let me know if this isn't preferred and I can revert it :)
Submitter Checklist:
git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist:
Tests