This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 970
Empty Ad Containers on Yahoo! #12918
Milestone
Comments
I would love to give it a try to fix! Can I work on it? |
adding #my-adsLDRB to the list in browser-laptop/app/extensions/brave/content/styles/removeEmptyElements.css should fix the problem |
10 tasks
bsclifton
added a commit
that referenced
this issue
Feb 12, 2018
Fixes issue #12918, hides empty ad container on www.yahoo.com
This was referenced Jun 11, 2018
@bsclifton Issue still persists on 0.23.8 |
The selector might have changed- did you want to check this out, @jonathansampson? |
Moving out of milestone; if we get a fix we can pull back in |
I would like to work on this :) |
@I3uckwheat awesome :D Thanks for taking it on. I've self-assigned this issue so no one else will take it :) Feel free to let myself or another team member know if you have any questions. 🎊 |
10 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Test plan
See #12964
Description
Brave is successfully blocking ads and trackers, but isn't removing empty ad containers. The following screenshot was procured from @spencernoon's tweet:
Steps to Reproduce
Actual result:
Empty ad containers are visible
Expected result:
Empty ad containers should be hidden
Reproduces how often:
Always
Brave Version
0.19.147
Reproducible on current live release:
Yes
Additional Information
There are additional ad containers as you browse the Yahoo! site.
Related to #8057
The text was updated successfully, but these errors were encountered: