Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Make release notes text modal scrollable #10639

Merged
merged 1 commit into from
Aug 23, 2017
Merged

Make release notes text modal scrollable #10639

merged 1 commit into from
Aug 23, 2017

Conversation

kjozwiak
Copy link
Member

Fix #9121

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@kjozwiak kjozwiak added design A design change, especially one which needs input from the design team. release-notes/include usability labels Aug 23, 2017
@kjozwiak kjozwiak added this to the 0.21.x (Nightly Channel) milestone Aug 23, 2017
@kjozwiak kjozwiak self-assigned this Aug 23, 2017
@kjozwiak kjozwiak requested a review from bbondy August 23, 2017 05:15
@bbondy
Copy link
Member

bbondy commented Aug 23, 2017 •
edited
Loading

lgtm thanks for fixing!

@bbondy bbondy merged commit 99dfe19 into master Aug 23, 2017
@luixxiul luixxiul deleted the releaseNotes-modal-text-scrollable branch September 21, 2017 05:06
@bsclifton bsclifton modified the milestones: 0.21.x (Nightly Channel), 0.19.x (Beta Channel) Sep 26, 2017
bsclifton pushed a commit that referenced this pull request Sep 26, 2017
@bbondy @bsclifton
Merge pull request #10639 from brave/releaseNotes-modal-text-scrollable
711df60 
Make release notes text modal scrollable
bsclifton pushed a commit that referenced this pull request Sep 26, 2017
@bbondy @bsclifton
Merge pull request #10639 from brave/releaseNotes-modal-text-scrollable
be304b2 
Make release notes text modal scrollable
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bbondy bbondy bbondy approved these changes

Assignees

@kjozwiak kjozwiak

Labels
design A design change, especially one which needs input from the design team. release-notes/include usability
Projects
None yet
Milestone
0.19.x (Beta Channel)
Development

Successfully merging this pull request may close these issues.
3 participants
@kjozwiak @bbondy @bsclifton