Release note modal text should be scrollable

[srirambv]

• Did you search for similar issues before submitting this one?
  Yes

• Describe the issue you encountered:
  With long release notes, update details modal doesn't fully show the text and covers the entire screen

• Platform (Win7, 8, 10? macOS? Linux distro?):
  Windows 10 x64

• Brave Version (revision SHA):
  Brave 0.16.0
  rev be76cd3
  Muon 3.2.101

• Steps to reproduce:

  1. Set browser version to a older verision in system variables
  2. Launch browser and click on check for update
  3. Modal is extra long and doens't show all text

• Screenshot if needed:
  screenshot take at maximized window
  
  Screenshot taken at restored position
  

• Any related issues: Alert box with quite lengthy content cannot be closed #7930 (comment)

[luixxiul]

@cezaraugusto do you have a solution like you did on #7930 to solve the bug?

Integrating Messagebox with Dialog to add scrollbar, keeping the position where Dialog appears (ie not tab-modal), would be a general solution here. In that way we could avoid Dialogs like BookmarkHanger from having the scrollbar when it overflows a browser window.

This is actually a bug, but not serious because you would never the long list of updates as long as your browser has been constantly updated, ie without setting the flag to test if the update works, the list normally would not overflow.

[alexwykoff]

@kjozwiak if you would like to give this a crack that'd be cool

[srirambv]

@bbondy @bsclifton can this be pulled into 0.19.x?

[bsclifton]

@srirambv sure- I updated milestone for this issue and the PR to 0.19.x

master 99dfe19
0.20.x be304b2
0.19.x 711df60

[srirambv]

Is this merged into 0.19.17? I still see the text overflow the modal

[srirambv]

Never mind its in 0.19.20