Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Brave update bar is misaligned #9370

Closed
diracdeltas opened this issue Jun 9, 2017 · 4 comments
Closed

Brave update bar is misaligned #9370

diracdeltas opened this issue Jun 9, 2017 · 4 comments
Labels
feature/navbar feature/notificationbar OS/macOS OS/Windows QA/checked-Win64 QA/test-plan-specified regression release-notes/exclude usability
Milestone
0.20.x (Release C...

Comments

@diracdeltas
Copy link
Member

diracdeltas commented Jun 9, 2017 •
edited by luixxiul
Loading

Test plan

#10512 (comment)

noticed this on OSX when updating from 0.15.x release to 0.16.6:
screen shot 2017-06-09 at 8 34 01 am
@cezaraugusto cezaraugusto added design A design change, especially one which needs input from the design team. regression labels Jun 9, 2017
@cezaraugusto cezaraugusto added this to the 0.18.x milestone Jun 9, 2017
@cezaraugusto cezaraugusto self-assigned this Jun 9, 2017
@luixxiul
Copy link
Contributor

@cezaraugusto Adding margin-bottom: @navbarMenubarMargin to navigationWrapper only when the update bar is displayed should be the solution as I tried. Adding margin-top to the update bar is not the proper way as there is applied no-drag.

@luixxiul
Copy link
Contributor

Test plan (proposal)

  • Try to update via menu
  • Make sure the area around the update bar can be grabbed [1]
  • DIsplay the bookmark toolbar
  • [1]
  • Hide the bookmark toolbar
  • Open enough tabs to display the tab pages
  • [1]

referring the test plan described on #7740 (comment).

@cezaraugusto
Copy link
Contributor

@luixxiul assigned you as well. I think you found the solution already so pls feel free to jump in

@alexwykoff alexwykoff modified the milestones: 0.19.x, 0.18.x (Frozen, only critical adds from here) Jun 12, 2017
@bsclifton bsclifton added usability and removed bug design A design change, especially one which needs input from the design team. labels Jul 18, 2017
@alexwykoff alexwykoff removed this from the 0.19.x (Beta Channel) milestone Jul 18, 2017
@bsclifton bsclifton mentioned this issue Aug 15, 2017
Closed
@luixxiul luixxiul removed their assignment Aug 15, 2017
@luixxiul
Copy link
Contributor

@petemill if you have some time would you mind addressing this issue??

petemill added a commit to petemill/browser-laptop that referenced this issue Aug 15, 2017
@petemill
Fix vertical spacing for navbar item combinations
44b3afc 
Fix brave#9370 by using collapsible margin so that items without border+padding can be evenly spaced (caption buttons, bookmark, tab pages), and those with border+padding (notifications, tabs) can be touching. Removes empty element for tab pages when there is only a single page, as it had no functional purpose. Instead, margin is used.
@petemill petemill mentioned this issue Aug 15, 2017
Merged
8 tasks
@bsclifton bsclifton added this to the 0.21.x (Nightly Channel) milestone Aug 15, 2017
petemill added a commit to petemill/browser-laptop that referenced this issue Aug 23, 2017
@petemill
Fix vertical spacing for navbar item combinations
2eeeb84 
Fix brave#9370 by using collapsible margin so that items without border+padding can be evenly spaced (caption buttons, bookmark, tab pages), and those with border+padding (notifications, tabs) can be touching. Removes empty element for tab pages when there is only a single page, as it had no functional purpose. Instead, margin is used.
petemill added a commit to petemill/browser-laptop that referenced this issue Aug 23, 2017
@petemill
Fix vertical spacing for navbar item combinations
e7c03ae 
Fix brave#9370 by using collapsible margin so that items without border+padding can be evenly spaced (caption buttons, bookmark, tab pages), and those with border+padding (notifications, tabs) can be touching. Removes empty element for tab pages when there is only a single page, as it had no functional purpose. Instead, margin is used.
petemill added a commit to petemill/browser-laptop that referenced this issue Aug 23, 2017
@petemill
Fix vertical spacing for navbar item combinations
fdaf601 
Fix brave#9370 by using collapsible margin so that items without border+padding can be evenly spaced (caption buttons, bookmark, tab pages), and those with border+padding (notifications, tabs) can be touching. Removes empty element for tab pages when there is only a single page, as it had no functional purpose. Instead, margin is used.
petemill added a commit to petemill/browser-laptop that referenced this issue Aug 23, 2017
@petemill
Fix vertical spacing for navbar item combinations
9690bf6 
Fix brave#9370 by using collapsible margin so that items without border+padding can be evenly spaced (caption buttons, bookmark, tab pages), and those with border+padding (notifications, tabs) can be touching. Removes empty element for tab pages when there is only a single page, as it had no functional purpose. Instead, margin is used.
@bbondy bbondy modified the milestones: 0.21.x (Developer Channel), 0.20.x (Beta Channel) Oct 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature/navbar feature/notificationbar OS/macOS OS/Windows QA/checked-Win64 QA/test-plan-specified regression release-notes/exclude usability
Projects
None yet
Milestone
0.20.x (Release Channel)
Development

No branches or pull requests
7 participants
@diracdeltas @bbondy @alexwykoff @luixxiul @cezaraugusto @bsclifton @srirambv