Button text needs padding-bottom

[srirambv]

• Did you search for similar issues before submitting this one?
  Yes

• Describe the issue you encountered:
  Button text needs padding-bottom

• Platform (Win7, 8, 10? macOS? Linux distro?):
  Windows 10 x64

• Brave Version (revision SHA):
  0.18.14/0.18.22

• Screenshot if needed:
  Top : 0.18.14
  Bottom : 0.18.22
  

• Any related issues:
  cc: @luixxiul

[luixxiul]

@srirambv could you please try to reproduce the issue on 0.19? thanks!

[luixxiul]

also please check if the issue is reproduced on about:styles, thanks.

[srirambv]

Checking on 0.19 but looks fine on about:styles in 0.18.22

[luixxiul]

The issue is not reproduced for me.

Didn't you changed the DPI setting or something?

[srirambv]

This is on a clean install of 0.18.20 and no changes to UI Scale or default zoom

This is on 0.18.22

[luixxiul]

maybe font rendering on chromium has changed and that could be a reason. CC @cezaraugusto do you know something on this?

[bsclifton]

@srirambv @luixxiul Is this issue a duplicate of #9370?

[luixxiul]

@bsclifton I don't think so, as this issue discusses the padding inside the buttons. #9370 is definitely worth fixing soon, but I'm afraid I don't know how to do.

[luixxiul]

@srirambv would you mind checking that setting display: flex and justify-content: center and align-items: center to the button elements would fix the issue?

[srirambv]

@luixxiul No change even with the settings override that you provided.

[luixxiul]

@srirambv do you see the same thing on about:styles? nvm I confirmed that on 0.18.29.

It seems to be caused by the difference of border-width. I'm working on a solution.

[luixxiul]

I think that reducing border-width of the primary button to 1px would fix the issue most easily but I am afraid it would cause an a11y issue (white border gets less noticiable by doing so).

[bsclifton]

This has been fixed a while ago