Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

"Remove Bookmark" button hard to read on hover #5894

Closed
jonathansampson opened this issue Nov 29, 2016 · 4 comments · Fixed by #5705 or #5916
Closed

"Remove Bookmark" button hard to read on hover #5894

jonathansampson opened this issue Nov 29, 2016 · 4 comments · Fixed by #5705 or #5916
Labels
accessibility bug design A design change, especially one which needs input from the design team. feature/bookmarks misc/button QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.13.0

Comments

@jonathansampson
Copy link
Collaborator

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
The text on the Remove button (within the Edit Bookmark dialog) is hard to read when the user hovers the button.

Expected behavior:
The text is always easy to read.

Platform (Win7, 8, 10? macOS? Linux distro?): Windows 10

Brave Version: 0.12.10

Screenshot if needed:
edit-bookmark-hover
@jonathansampson jonathansampson added accessibility bug design A design change, especially one which needs input from the design team. feature/bookmarks labels Nov 29, 2016
@jonathansampson jonathansampson mentioned this issue Nov 29, 2016
Closed
@bsclifton bsclifton modified the milestones: 0.13.0, 0.13.1 Nov 29, 2016
@bsclifton
Copy link
Member

bsclifton commented Nov 29, 2016 •
edited
Loading

Tentatively assigning to 0.13.1; @jkup I know you're working on #5801 (which this should be a part of)

@jkup jkup mentioned this issue Nov 29, 2016
Merged
4 tasks
@luixxiul
Copy link
Contributor

luixxiul commented Dec 1, 2016

I fixed the issue with #5705

@luixxiul
Copy link
Contributor

luixxiul commented Dec 1, 2016

Confirmed it was fixed on 0.13.0 Preview2

@luixxiul luixxiul closed this as completed Dec 1, 2016
@luixxiul luixxiul modified the milestones: 0.13.0, 0.13.1 Dec 1, 2016
This was referenced Dec 20, 2016
Closed
Closed
Closed
Closed
@alexwykoff alexwykoff mentioned this issue Dec 20, 2016
Closed
@luixxiul luixxiul mentioned this issue Jan 16, 2017
Merged
4 tasks
@luixxiul
Copy link
Contributor

Test plan: based on 23207ed

  1. Click the bookmark button on the URL bar
  2. Make sure color of "Remove" label is no longer white on hover

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accessibility bug design A design change, especially one which needs input from the design team. feature/bookmarks misc/button QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.13.0
5 participants
@jkup @jonathansampson @luixxiul @bsclifton @srirambv