Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Make button styles consistent #5801

Closed
jkup opened this issue Nov 22, 2016 · 6 comments · Fixed by #5916
Closed

Make button styles consistent #5801

jkup opened this issue Nov 22, 2016 · 6 comments · Fixed by #5916
Assignees
Labels
Milestone

Comments

@jkup
Copy link
Contributor

jkup commented Nov 22, 2016

This awesome screenshot from @bsclifton shows inconsistencies in our primary and white buttons. We should make them all look identical re: font-size, color and font-weight.
pasted image at 2016_11_22 03_29 pm

@jkup jkup added the design A design change, especially one which needs input from the design team. label Nov 22, 2016
@jkup jkup added this to the 0.13.0 milestone Nov 22, 2016
@jkup jkup self-assigned this Nov 22, 2016
@luixxiul
Copy link
Contributor

#5705 should fix some of them.

@jkup
Copy link
Contributor Author

jkup commented Nov 27, 2016

It actually looks like these discrepancies are intentional. If you inspect those bold buttons or the white one with orange text you'll see custom classes like secondaryAltButton are responsible.

@bradleyrichter is it desired to have some buttons (import browser data for example) with bold white text and some white buttons with orange text or should they all look 100% consistent?
screen shot 2016-11-27 at 1 46 57 pm

@bradleyrichter
Copy link
Contributor

@jkup They should all match this pair:

image

Here is are the specs for the button styles:

image

@jkup
Copy link
Contributor Author

jkup commented Nov 27, 2016

@bradleyrichter Ok awesome! I'm going to remove all these additional classes so they all look the same!

@bradleyrichter
Copy link
Contributor

Awesome. And then I can refine them like a boss. (soften up the shadows and blends)

@luixxiul
Copy link
Contributor

Test plan: #5916 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants