"remember password" odd behavior

[diegodoval]

Did you search for similar issues before submitting this one?
yes

Describe the issue you encountered:
-on some sites the bar flashes in and disappears, on others it never shows up
-on developer.apple.com the 'remember this password?' bar flashes in and goes away. When logging out, it appears again. (verified multiple times, have screen recording if necessary)

That aside: sites that don’t show ‘remember password’ at all
citibank.com
imgur.com
gfycat.com

Sites that behave correctly:
reddit.com
amazon.com

Expected behavior:

• Platform (Win7, 8, 10? macOS? Linux distro?):
  Mac
• Brave Version:
  0.11.2
• Steps to reproduce:
  1.
  2.
  3.
• Screenshot if needed:
• Any related issues: Flash notification bar appears twice during loading of siriusxm.com #4276

[diracdeltas]

the flashing-and-disappearing issue may be due to d1b09e4 if the post-login URL is a different origin than the login page

[bsclifton]

+1 from support

When I use a new password and the pop-up asks me if I
want to save it, the pop-up goes away too fast. I don't have enough time
to drag my mouse over to answer yes.

[alexwykoff]

+1 from support https://linkbubble.zendesk.com/agent/tickets/6209

[luixxiul]

Another: https://community.brave.com/t/save-password-button-disappears-too-quickly/580

[diracdeltas]

seems like a lot of complaints compared to the previous behavior where the password message box lingered until you closed it manually. i can change it back.

[bradleyrichter]

@diracdeltas Is it now tab specific? Or window specific?

Perhaps it can auto-close when the domain changes instead of being page level?

[diracdeltas]

Perhaps it can auto-close when the domain changes instead of being page level?

that was the cause of this issue actually

[bradleyrichter]

Ah..so the only choice is to keep it around until the tab is closed? (assuming it was not acted upon)

[diracdeltas]

right now it doesn't close unless you close it. at the time this was implemented, there was no good way to specify a particular frame that the message box belonged to. may be possible now.

[luixxiul]

Test plan: b466a44