Skip to content

Commit

Permalink
show password manager message box on all origins
Browse files Browse the repository at this point in the history
fix brave#2957
note that this partially un-fixes brave#1928.

Auditors: @alexwykoff

Test Plan:
1. go to developer.apple.com
2. click on 'Account' in the top right
3. enter your apple username and password
4. the login page should redirect to https://developer.apple.com/
5. after the redirect, you should still see a password manager dialog from Brave that says 'Would you like Brave to remember the password for [username] on https://idmsa.apple.com?'
  • Loading branch information
diracdeltas authored and bkilrain committed Jan 13, 2017
1 parent e576aa7 commit 97ed6ff
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions app/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -676,11 +676,9 @@ app.on('ready', () => {
],
options: {
persist: false,
frameOrigin: origin,
advancedText: locale.translation('notificationPasswordSettings'),
advancedLink: 'about:passwords'
},
frameOrigin: origin,
message
})
}
Expand Down

0 comments on commit 97ed6ff

Please sign in to comment.