Disable domain block #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iefremov
commented
Apr 9, 2021
seed/seed.json
Outdated
| } | ||
| ], | ||
| "filter": { | ||
| "max_version": "89.1.23", |
iefremov
commented
Apr 9, 2021
| ], | ||
| "filter": { | ||
| "max_version": "89.1.23", | ||
| "channel": ["RELEASE"], |
There was a problem hiding this comment.
only stable channel is affected
iefremov
force-pushed
the
disable_domain_block
branch
from
07fc35b to
033a79b
Compare
iefremov
force-pushed
the
disable_domain_block
branch
from
033a79b to
102696f
Compare
kjozwiak
approved these changes
Apr 9, 2021
There was a problem hiding this comment.
LGTM 👍 QA went through the following on staging as per brave/brave-browser#15149 (comment). BTW, can't merge as I don't have write access to https://github.com/brave/brave-variations
|
@iefremov we'll want to revert this as we're going via the PR route via brave/brave-core#8507. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.