Confirm first party domain blocking (#14134) off in Release Channel build #15149

LaurenWags · 2021-04-06T17:01:31Z

Placeholder to confirm #14134 is off by default on Release Channel builds.

Example:

Visit one of the sites listed in #14134 (comment) such as:

1-1ads.com
actionsplash.com
pub.chez.com

Confirm that the site loads as expected, this means that first-party domain blocking is off by default. This is the expected outcome at this time.

However, if the site is blocked then first-party domain blocking is on by default. This should not be the case for Release Channel builds at this time.

The text was updated successfully, but these errors were encountered:

LaurenWags · 2021-04-06T17:01:52Z

@brave/legacy_qa we will need a 1.23.x RC to check this issue.

kjozwiak · 2021-04-07T19:08:51Z

Basically what @LaurenWags mentioned above but here's more detailed STR/Cases. I picked pub.chez.com but any of the ones that @LaurenWags mentioned above can be used as well.

Verify domain blocking is disabled on release channel - visit pub.chez.com and make sure there isn't a Suspicious site ahead interstitial screen being loaded/displayed
Verify domain blocking can be enabled on release channel - go to brave://flags, set #brave-domain-block to Enabled, visit pub.chez.com, and make sure that there is a Suspicious site ahead interstitial screen being loaded/displayed
Repeat the above using either Nightly/Dev/BETA and you make sure having #brave-domain-block as Default causes the Suspicious site ahead interstitial to appear

LaurenWags · 2021-04-08T12:17:48Z

Removing QA/Blocked since https://github.com/brave/brave-browser/releases/tag/v1.23.68 is available

kjozwiak · 2021-04-08T15:46:31Z

Waiting on @iefremov to push these changes into Griffen.

kjozwiak · 2021-04-09T20:02:33Z

Worked with @iefremov and went through the following on Staging and ensured Top Level Domain Blocking was disabled:

`1.23.x Test Case`

Launched 1.23.69 CR: 90.0.4430.61 using the following:

brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed

Note: You'll need to restart the browser after the initial launch using the same switch. Once relaunched, checked brave://version/?show-variations-cmd and ensured the following:

Check brave://local-state/ and ensure that you see data re: the variation server/seed as per the following:

   },
   "variations_compressed_seed": "safe_seed_content",
   "variations_country": "CA",
   "variations_crash_streak": 0,
   "variations_failed_to_fetch_seed_streak": 0,
   "variations_last_fetch_time": "13262471257436368",
   "variations_permanent_consistency_country": [ "90.1.23.69", "CA" ],
   "variations_safe_compressed_seed": "H4sIAAAAAAAAAL3OPQ/BQACA4TskOEtzSUUsGtPFcOmXatemFiN/wF3vSqMfUiWxEv9bG4MUs3d+hwdp3DTn3DVtx+BV0nEcL1qEOg+51EPLZvgGkeoX7CKDPGVx5id5eNiUZ3F14WqCusuM8UQKBXCMlM9vpaFeEJ9eh+AYfx8D1A1kxM5JqYC1Ou57OjWoadGZ1iaAQNIinS3E9wqxPO5lKguWbMq8YDv5AyFqxOfXQIAa8XU0EEOMXK9GGHRhNRSPPypGDQXQWm/HFBpPuM9RyLgBAAA=",
   "variations_safe_seed_date": "13262471142000000",
   "variations_safe_seed_fetch_time": "13262471257436368",
   "variations_safe_seed_locale": "en-GB",
   "variations_safe_seed_permanent_consistency_country": "CA",
   "variations_safe_seed_session_consistency_country": "CA",
   "variations_safe_seed_signature": "MEQCIAOkK3lKIetQ3piryhqQox29I1N501knG8pcpXbic695AiAK7lwK1IP07f/mrLZXdo8o3wjblJyZ7pWeMNnpUsy5gQ==",
   "variations_seed_date": "13262471257000000",
   "variations_seed_signature": "MEQCIAOkK3lKIetQ3piryhqQox29I1N501knG8pcpXbic695AiAK7lwK1IP07f/mrLZXdo8o3wjblJyZ7pWeMNnpUsy5gQ==",
   "was": {
      "restarted": false
   }

Once the above has been confirmed, checked the following websites and ensured that the interstitials page wasn't being displayed.

1-1ads.com - PASSED
actionsplash.com - PASSED
pub.chez.com - PASSED

`1.25.x Test Case`

Launched 1.25.4 CR: 90.0.4430.51 using the following:

brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed --fake-variations-channel=stable

Once the above has been confirmed, checked the following websites and ensured that the interstitials page was being displayed.

1-1ads.com - PASSED
actionsplash.com - PASSED
pub.chez.com - PASSED

kjozwiak · 2021-04-12T06:21:35Z

Unblocking as brave/brave-variations#14 has been merged into production. There's still one issue re: new installs needing to restart the browser. Still TBD if this will get addressed by 1.23.x or later.

srirambv · 2021-04-12T11:12:10Z

Verification passed on OnePlus 6T with Android 10 running 1.23.69 x64 build

Verified test plan from Confirm first party domain blocking (#14134) off in Release Channel build #15149 (comment)
Verified variations are shown in brave://version/?show-variations-cmd
Verified websites like 1-1ads.com & actionsplash.com don't show interstitial page when loaded
Verified without variations the above pages show interstitial page
Verified brave://local-state shows variations log

   },
   "variations_compressed_seed": "H4sIAAAAAAAAAL3OPQ/BQACA4TskOEtzSUUsGtPFcOmXatemFiN/wF3vSqMfUiWxEv9bG4MUs3d+hwdp3DTn3DVtx+BV0nEcL1qEOg+51EPLZvgGkeoX7CKDPGVx5id5eNiUZ3F14WqCusuM8UQKBXCMlM9vpaFeEJ9eh+AYfx8D1A1kxM5JqYC1Ou57OjWoadGZ1iaAQNIinS3E9wqxPO5lKguWbMq8YDv5AyFqxOfXQIAa8XU0EEOMXK9GGHRhNRSPPypGDQXQWm/HFBpPuM9RyLgBAAA=",
   "variations_country": "IN",
   "variations_crash_streak": 0,
   "variations_failed_to_fetch_seed_streak": 0,
   "variations_last_fetch_time": "13262696710793465",
   "variations_permanent_consistency_country": [ "90.1.23.69", "IN" ],
   "variations_safe_compressed_seed": "H4sIAAAAAAAAAL3OPQuCQACA4TsLrGuRgyJakiZpEO/KrzV0caw/0OmdFVmGadBa9L9TGkJtbni3d3iQG5scOMTklBluavMyKljy2KDVsS4QRdfEDouEqYzfhpSd2OK+SNDpu8oLfHRhMkeyfWZgIroAQI6X5BSrqeYfr5+Ahxu1jgGRPxKxIcgWsh5O+a+hEpwt9rnY0oEFN0rpbiJ8lwr/sxUlkLNnkacZ24geCV4jmV0OACtE6aogRRo5bIYhuL2qK1x8V45oCqNLXMYPkDcntuxi4AQAA",
   "variations_safe_seed_date": "13262694873000000",
   "variations_safe_seed_fetch_time": "13262694876299507",
   "variations_safe_seed_locale": "en-US",
   "variations_safe_seed_permanent_consistency_country": "IN",
   "variations_safe_seed_session_consistency_country": "IN",
   "variations_safe_seed_signature": "MEUCIQD0oqynrJRGgJNLQUhz/SzgdVJNRw8WU7YmNgaS5x6BOAIgHetkiltEjq17sF/0+aTx2wnCssKhnuCCImSSWrs5nTU=",
   "variations_seed_date": "13262696711000000",
   "variations_seed_signature": "MEQCIAOkK3lKIetQ3piryhqQox29I1N501knG8pcpXbic695AiAK7lwK1IP07f/mrLZXdo8o3wjblJyZ7pWeMNnpUsy5gQ=="
}

Verification passed on Samsung Tab A with Android 10 running 1.23.69 x64 build

Verified test plan from Confirm first party domain blocking (#14134) off in Release Channel build #15149 (comment)
Verified variations are shown in brave://version/?show-variations-cmd
Verified websites like 1-1ads.com & actionsplash.com don't show interstitial page when loaded
Verified without variations the above pages show interstitial page
Verified brave://local-state shows variations log

},
   "variations_compressed_seed": "H4sIAAAAAAAAAL3OPQ/BQACA4TskOEtzSUUsGtPFcOmXatemFiN/wF3vSqMfUiWxEv9bG4MUs3d+hwdp3DTn3DVtx+BV0nEcL1qEOg+51EPLZvgGkeoX7CKDPGVx5id5eNiUZ3F14WqCusuM8UQKBXCMlM9vpaFeEJ9eh+AYfx8D1A1kxM5JqYC1Ou57OjWoadGZ1iaAQNIinS3E9wqxPO5lKguWbMq8YDv5AyFqxOfXQIAa8XU0EEOMXK9GGHRhNRSPPypGDQXQWm/HFBpPuM9RyLgBAAA=",
   "variations_country": "IN",
   "variations_crash_streak": 0,
   "variations_failed_to_fetch_seed_streak": 0,
   "variations_last_fetch_time": "13262694348918483",
   "variations_permanent_consistency_country": [ "90.1.23.69", "IN" ],
   "variations_safe_compressed_seed": "H4sIAAAAAAAAAL3OPQuCQACA4TsLrGuRgyJakiZpEO/KrzV0caw/0OmdFVmGadBa9L9TGkJtbni3d3iQGscOMTklBluavMyKljy2KDVsS4QRdfEDouEqYzfhpSd2OK+SNDpu8oLfHRhMkeyfWZgIroAQI6X5BSrqeYfr5+Ahxu1jgGRPxKxIcgWsh5O+a+hEpwt9rnY0oEFN0rpbiJ8lwr/sxUlkLNnkacZ24geCV4jmV0OACtE6aogRRo5bIYhuL2qK1x8V45oCqNLXMYPkDcntuxi4AQAA",
   "variations_safe_seed_date": "13262688324000000",
   "variations_safe_seed_fetch_time": "13262688352684664",
   "variations_safe_seed_locale": "en-US",
   "variations_safe_seed_permanent_consistency_country": "IN",
   "variations_safe_seed_session_consistency_country": "IN",
   "variations_safe_seed_signature": "MEUCIQD0oqynrJRGgJNLQUhz/SzgdVJNRw8WU7YmNgaS5x6BOAIgHetkiltEjq17sF/0+aTx2wnCssKhnuCCImSSWrs5nTU=",
   "variations_seed_date": "13262694323000000",
   "variations_seed_signature": "MEQCIAOkK3lKIetQ3piryhqQox29I1N501knG8pcpXbic695AiAK7lwK1IP07f/mrLZXdo8o3wjblJyZ7pWeMNnpUsy5gQ=="
}

Note: I did have to restart the browser multiple times and visit the test sites before the entire variation logs showed up. This is a known issue for now

btlechowski · 2021-04-12T14:13:36Z

Verification passed on

Brave	1.23.69 Chromium: 90.0.4430.61 (Official Build) (64-bit)
Revision	dced74d4124b26b14126b611853d33512b60c7b6-refs/branch-heads/4430@{#1115}
OS	Ubuntu 18.04 LTS

Verified test plan from #15149 (comment) on Brave release and variation seed production server

Verified that the interstitials page wasn't being displayed

1-1ads.com - PASSED - page was unreachable
actionsplash.com - PASSED
pub.chez.com - PASSED

Local state:

   "variations_compressed_seed": "safe_seed_content",
   "variations_country": "PL",
   "variations_crash_streak": 0,
   "variations_failed_to_fetch_seed_streak": 0,
   "variations_last_fetch_time": "13262692233083652",
   "variations_permanent_consistency_country": [ "90.1.23.69", "PL" ],
   "variations_safe_compressed_seed": "H4sIAAAAAAAAAL3OPQuCQACA4TsLrGuRgyJakiZpEO/KrzV0caw/0OmdFVmGadBa9L9TGkJtbni3d3iQGscOMTklBluavMyKljy2KDVsS4QRdfEDouEqYzfhpSd2OK+SNDpu8oLfHRhMkeyfWZgIroAQI6X5BSrqeYfr5+Ahxu1jgGRPxKxIcgWsh5O+a+hEpwt9rnY0oEFN0rpbiJ8lwr/sxUlkLNnkacZ24geCV4jmV0OACtE6aogRRo5bIYhuL2qK1x8V45oCqNLXMYPkDcntuxi4AQAA",
   "variations_safe_seed_date": "13262709688000000",
   "variations_safe_seed_fetch_time": "13262692182803848",
   "variations_safe_seed_locale": "en-US",
   "variations_safe_seed_permanent_consistency_country": "PL",
   "variations_safe_seed_session_consistency_country": "PL",
   "variations_safe_seed_signature": "MEUCIQD0oqynrJRGgJNLQUhz/SzgdVJNRw8WU7YmNgaS5x6BOAIgHetkiltEjq17sF/0+aTx2wnCssKhnuCCImSSWrs5nTU=",
   "variations_seed_date": "13262709825000000",
   "variations_seed_signature": "MEUCIQD0oqynrJRGgJNLQUhz/SzgdVJNRw8WU7YmNgaS5x6BOAIgHetkiltEjq17sF/0+aTx2wnCssKhnuCCImSSWrs5nTU=",
   "was": {
      "restarted": false
   }

Verification passed on

Brave | 1.23.69 Chromium: 90.0.4430.61 (Official Build) (64-bit)
-- | --
Revision | dced74d4124b26b14126b611853d33512b60c7b6-refs/branch-heads/4430@{#1115}
OS | Windows 10 OS Version 2004 (Build 19041.867)

Verified test plan from #15149 (comment) on Brave release and variation seed production server

Verified that the interstitials page wasn't being displayed

1-1ads.com - PASSED - page was unreachable
actionsplash.com - PASSED
pub.chez.com - PASSED

Local state:

 "variations_compressed_seed": "safe_seed_content",
   "variations_country": "IN",
   "variations_crash_streak": 0,
   "variations_failed_to_fetch_seed_streak": 0,
   "variations_last_fetch_time": "13262713529456170",
   "variations_permanent_consistency_country": [ "90.1.23.69", "IN" ],
   "variations_safe_compressed_seed": "H4sIAAAAAAAAAL3OPQuCQACA4TsLrGuRgyJakiZpEO/KrzV0caw/0OmdFVmGadBa9L9TGkJtbni3d3iQGscOMTklBluavMyKljy2KDVsS4QRdfEDouEqYzfhpSd2OK+SNDpu8oLfHRhMkeyfWZgIroAQI6X5BSrqeYfr5+Ahxu1jgGRPxKxIcgWsh5O+a+hEpwt9rnY0oEFN0rpbiJ8lwr/sxUlkLNnkacZ24geCV4jmV0OACtE6aogRRo5bIYhuL2qK1x8V45oCqNLXMYPkDcntuxi4AQAA",
   "variations_safe_seed_date": "13262713349000000",
   "variations_safe_seed_fetch_time": "13262713529456170",
   "variations_safe_seed_locale": "en-US",
   "variations_safe_seed_permanent_consistency_country": "IN",
   "variations_safe_seed_session_consistency_country": "IN",
   "variations_safe_seed_signature": "MEUCIQD0oqynrJRGgJNLQUhz/SzgdVJNRw8WU7YmNgaS5x6BOAIgHetkiltEjq17sF/0+aTx2wnCssKhnuCCImSSWrs5nTU=",
   "variations_seed_date": "13262713530000000",
   "variations_seed_signature": "MEUCIQD0oqynrJRGgJNLQUhz/SzgdVJNRw8WU7YmNgaS5x6BOAIgHetkiltEjq17sF/0+aTx2wnCssKhnuCCImSSWrs5nTU=",
   "was": {
      "restarted": false

kjozwiak · 2021-04-13T02:24:03Z

Closing as @pilgrim-brave fixed/merged brave/brave-core#8507 into 1.23.x. We'll need to retest the above once we get a new 1.23.x RC.

(see brave/brave-browser#15149)

LaurenWags · 2021-04-13T12:10:55Z

Adding QA/Blocked until a new RC is built per #15149 (comment)

stephendonner · 2021-04-13T22:29:35Z

Removing QA/Blocked as we have a new 1.23.70 build.

Verified PASSED using

Brave	1.23.70 Chromium: 90.0.4430.70 (Official Build) (x86_64)
Revision	3954de7175366f3b7edca576f140dfa273e6b5ae-refs/branch-heads/4430@{#1210}
OS	macOS Version 11.2.3 (Build 20D91)

Tested and ensured that 1st-party domain blocking is OFF by successfully loading:

actionsplash.com	adap.tv	pub.chez.com

Verification PASSED on Ubuntu 20.04 x64 using the following build:

Brave | 1.23.70 Chromium: 90.0.4430.70 (Official Build) (64-bit)
--- | ---
Revision | 3954de7175366f3b7edca576f140dfa273e6b5ae-refs/branch-heads/4430@{#1210}
OS  | Linux

ensured that BraveDomainBlockStudy wasn't being listed under brave://version/?show-variations-cmd
restarted several times and ensured that a new variation seed wasn't downloaded/used for BraveDomainBlockStudy
ensured that actionsplash.com, adap.tv, pub.chez.com & 1-1ads.com weren't being blocked

`Variation/Seed`	`actionsplash.com`	`adap.tv`	`pub.chez.com`	`1-1ads.com`

Verification passed on

Brave | 1.23.70 Chromium: 90.0.4430.70 (Official Build) (64-bit)
-- | --
Revision | 3954de7175366f3b7edca576f140dfa273e6b5ae-refs/branch-heads/4430@{#1210}
OS | Windows 10 OS Version 2004 (Build 19041.867)

ensured that BraveDomainBlockStudy wasn't being listed under brave://version/?show-variations-cmd
restarted several times and ensured that a new variation seed wasn't downloaded/used for BraveDomainBlockStudy
ensured that actionsplash.com, adap.tv, pub.chez.com & 1-1ads.com weren't being blocked

`Variation/Seed`	`actionsplash.com`	`adap.tv`	`pub.chez.com`	`1-1ads.com`

srirambv · 2021-04-14T05:58:42Z

Verification passed on OnePlus 6T with Android 10 running 1.23.70

Verified domain block is set to default OFF
Verified visiting the test domains doesn't show safe browsing interstitial page

Verification passed on Samsung Tab A with Android 10 running 1.23.70

Verified domain block is set to default OFF
Verified visiting the test domains doesn't show safe browsing interstitial page

LaurenWags added QA/Yes release-notes/exclude QA/Blocked OS/Android Fixes related to Android browser functionality OS/Desktop labels Apr 6, 2021

LaurenWags added this to the 1.23.x - Beta milestone Apr 6, 2021

LaurenWags closed this as completed Apr 6, 2021

LaurenWags removed the QA/Blocked label Apr 8, 2021

kjozwiak added the QA/Blocked label Apr 8, 2021

LaurenWags added the QA/Test-All-Platforms label Apr 9, 2021

kjozwiak removed the QA/Blocked label Apr 12, 2021

srirambv added QA Pass - Android ARM QA Pass - Android Tab labels Apr 12, 2021

btlechowski added the QA Pass-Linux label Apr 12, 2021

bbondy reopened this Apr 12, 2021

bbondy removed QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux labels Apr 12, 2021

bbondy mentioned this issue Apr 12, 2021

Disable domain blocking via feature flag brave/brave-core#8507

Merged

24 tasks

kjozwiak added the release/blocking label Apr 12, 2021

kjozwiak closed this as completed Apr 13, 2021

iefremov added a commit to brave/brave-variations that referenced this issue Apr 13, 2021

Reenable domain blocking as this is managed in the code.

e03af3a

(see brave/brave-browser#15149)

iefremov mentioned this issue Apr 13, 2021

Reenable domain blocking as this is managed in the code. brave/brave-variations#15

Merged

LaurenWags added the QA/Blocked label Apr 13, 2021

LaurenWags mentioned this issue Apr 13, 2021

First-party domain blocking #14134

Closed

stephendonner added QA Pass-macOS and removed QA/Blocked labels Apr 13, 2021

srirambv added QA Pass - Android ARM QA Pass - Android Tab labels Apr 14, 2021

kjozwiak added the QA Pass-Linux label Apr 14, 2021

GeetaSarvadnya added the QA Pass-Win64 label Apr 14, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Confirm first party domain blocking (#14134) off in Release Channel build #15149

Confirm first party domain blocking (#14134) off in Release Channel build #15149

LaurenWags commented Apr 6, 2021

LaurenWags commented Apr 6, 2021

kjozwiak commented Apr 7, 2021 •

edited

Loading

LaurenWags commented Apr 8, 2021

kjozwiak commented Apr 8, 2021

kjozwiak commented Apr 9, 2021 •

edited

Loading

kjozwiak commented Apr 12, 2021

srirambv commented Apr 12, 2021 •

edited

Loading

btlechowski commented Apr 12, 2021 •

edited by GeetaSarvadnya

Loading

kjozwiak commented Apr 13, 2021

LaurenWags commented Apr 13, 2021

stephendonner commented Apr 13, 2021 •

edited by GeetaSarvadnya

Loading

srirambv commented Apr 14, 2021

Confirm first party domain blocking (#14134) off in Release Channel build #15149

Confirm first party domain blocking (#14134) off in Release Channel build #15149

Comments

LaurenWags commented Apr 6, 2021

LaurenWags commented Apr 6, 2021

kjozwiak commented Apr 7, 2021 • edited Loading

LaurenWags commented Apr 8, 2021

kjozwiak commented Apr 8, 2021

kjozwiak commented Apr 9, 2021 • edited Loading

1.23.x Test Case

1.25.x Test Case

kjozwiak commented Apr 12, 2021

srirambv commented Apr 12, 2021 • edited Loading

btlechowski commented Apr 12, 2021 • edited by GeetaSarvadnya Loading

kjozwiak commented Apr 13, 2021

LaurenWags commented Apr 13, 2021

stephendonner commented Apr 13, 2021 • edited by GeetaSarvadnya Loading

srirambv commented Apr 14, 2021

kjozwiak commented Apr 7, 2021 •

edited

Loading

kjozwiak commented Apr 9, 2021 •

edited

Loading

`1.23.x Test Case`

`1.25.x Test Case`

srirambv commented Apr 12, 2021 •

edited

Loading

btlechowski commented Apr 12, 2021 •

edited by GeetaSarvadnya

Loading

stephendonner commented Apr 13, 2021 •

edited by GeetaSarvadnya

Loading