Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Expand Rewards to three decimal places #2638

Merged
merged 1 commit into from
Jun 16, 2020
Merged

Expand Rewards to three decimal places #2638

merged 1 commit into from
Jun 16, 2020

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Jun 16, 2020

Summary of Changes

This pull request fixes #2596

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()

Test Plan:

See brave/brave-browser#10027

Screenshots:

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • release-notes/(include|exclude)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue is assigned to a milestone (should happen at merge time).

@tmancey tmancey self-assigned this Jun 16, 2020
return String(format: "%.1f", value)
return String(format: "%.3f", value)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know we're having this conversation already but just to document: Are we sure we want to always show 3 decimal places instead of a min/max number of decimals shown based on the value itself? We can easily do this with NumberFormatter

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we always show 3 decimal places for desktop, I will merge as-is. And if a decision is made to change we should raise a new issue for all platforms

@tmancey tmancey modified the milestone: 1.19 Jun 16, 2020
@tmancey tmancey merged commit cb56d04 into development Jun 16, 2020
@tmancey tmancey deleted the fix-2596 branch June 16, 2020 20:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expand Rewards to three decimal places
3 participants