Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Desktop] Expand Rewards to three decimal places #10027

Closed
jsecretan opened this issue Jun 1, 2020 · 1 comment · Fixed by brave/brave-core#5699
Closed

[Desktop] Expand Rewards to three decimal places #10027

jsecretan opened this issue Jun 1, 2020 · 1 comment · Fixed by brave/brave-core#5699
Assignees
@tmancey
Labels
enhancement feature/ads priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.11.x - Release #1

Comments

@jsecretan
Copy link

jsecretan commented Jun 1, 2020 •
edited by tmancey
Loading

Description

Currently the estimated pending rewards display on the brave://rewards page, the estimated pending rewards display on the new tab page widget, and the ad grant claimed amounts round to one decimal place. They should round to 3 decimal places so that users can see ads that yield less than 0.1 BAT per view
@jsecretan jsecretan added the priority/P1 A very extremely bad problem. We might push a hotfix for it. label Jun 1, 2020
@tmancey tmancey added enhancement and removed bug priority/P1 A very extremely bad problem. We might push a hotfix for it. labels Jun 1, 2020
@tmancey tmancey mentioned this issue Jun 1, 2020
Closed
@tmancey tmancey mentioned this issue Jun 1, 2020
Merged
32 tasks
@tmancey tmancey added QA/Yes release-notes/include priority/P1 A very extremely bad problem. We might push a hotfix for it. labels Jun 1, 2020
@jsecretan jsecretan changed the title Expand estimated pending rewards to two decimal places Expand estimated pending rewards to three decimal places Jun 2, 2020
@tmancey tmancey changed the title Expand estimated pending rewards to three decimal places Expand Rewards to three decimal places Jun 2, 2020
@tmancey tmancey mentioned this issue Jun 2, 2020
Closed
@tmancey tmancey added this to the 1.12.x - Nightly milestone Jun 5, 2020
This was referenced Jun 13, 2020
Merged
Merged
@LaurenWags LaurenWags mentioned this issue Jun 24, 2020
Closed
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jun 26, 2020 •
edited by LaurenWags
Loading

Verification passed on


Brave | 1.11.78 Chromium: 83.0.4103.116 (Official Build) dev (64-bit)
-- | --
Revision | 8f0c18b4dca9b6699eb629be0f51810c24fb6428-refs/branch-heads/4103@{#716}
OS | Windows 10 OS Version 1903 (Build 18362.900)

Clean profile:

  • Viewed an ad and confirmed that brave://rewards Ads panel Estimated pending rewards displays 3 decimal places
    image
  • Verified that NTP widget Estimated earnings so far this month displays the 3 decimal places
    image

Upgrade profile:

  • Viewed an ad in 1.10.x and verified that 0.1 BAT Estimated pending rewards is accrued in Ada panel and NTP widget, upgrade profile to 1.11.x and verified that the Estimated pending rewards is rounded to 3 decimal places 0.050 BAT and same is shown in NTP widget

  • Verified that claimed ad grants is rounded to 3 decimal places in a clean profile
    Panel:
    image
    Summary:
    image
    Monthly statement:
    image

  • Verified that claimed ad grants is rounded to 3 decimal places in an upgraded profile
    Panel:
    image
    Summary:
    image
    Monthly statement:
    image

Verified passed with

Brave | 1.11.85 Chromium: 83.0.4103.116 (Official Build) dev (64-bit)
-- | --
Revision | 8f0c18b4dca9b6699eb629be0f51810c24fb6428-refs/branch-heads/4103@{#716}
OS | macOS Version 10.14.6 (Build 18G3020)

Areas checked:

  1. Claim Ad grant

Screen Shot 2020-07-02 at 8 11 16 AM

  1. Wallet Summary (brave://rewards and panel)

Screen Shot 2020-07-02 at 8 12 17 AM

  1. Ads panel

Screen Shot 2020-07-02 at 8 13 29 AM

  1. NTP widget

Screen Shot 2020-07-02 at 8 14 17 AM

  1. Monthly Statement

Screen Shot 2020-07-02 at 8 14 27 AM

Other places checked (but did not include screenshots):
6. AC panel/settings
7. Tip panels
8. UGP claim
9. Tip banners
10. Monthly Statement other than main page
11. Recurring Tip on panel

Verified passed with

Brave	1.11.87 Chromium: 83.0.4103.116 (Official Build) dev (64-bit)
Revision	8f0c18b4dca9b6699eb629be0f51810c24fb6428-refs/branch-heads/4103@{#716}
OS	Linux

Areas checked:

  1. Claim Ad grant

Screen Shot 2020-07-03 at 10 19 28 AM

  1. Wallet Summary (brave://rewards and panel)

Screen Shot 2020-07-03 at 10 20 17 AM

  1. Ads panel

Screen Shot 2020-07-03 at 10 20 33 AM

  1. NTP widget

Screen Shot 2020-07-03 at 10 20 47 AM

  1. Monthly Statement

Screen Shot 2020-07-03 at 10 20 58 AM

Other places checked (but did not include screenshots):
6. AC panel/settings
7. Tip panels
8. UGP claim
9. Tip banners
10. Monthly Statement other than main page
11. Recurring Tip on panel

@rebron rebron changed the title Expand Rewards to three decimal places [Desktop] Expand Rewards to three decimal places Jul 14, 2020
@LaurenWags LaurenWags mentioned this issue Jul 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
enhancement feature/ads priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Ads
Archived in project
Milestone
1.11.x - Release #1
Development

Successfully merging a pull request may close this issue.

Expand Rewards to three decimal places brave/brave-core
5 participants
@jsecretan @tmancey @kjozwiak @LaurenWags @GeetaSarvadnya