Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cr93 followup] Disables kReadLater feature. #9792

Merged
merged 2 commits into from
Aug 24, 2021

Conversation

mkarolin
Copy link
Collaborator

@mkarolin mkarolin commented Aug 19, 2021

Fixes brave/brave-browser#17573

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@mkarolin mkarolin requested review from jumde and bsclifton August 19, 2021 18:03
@mkarolin mkarolin self-assigned this Aug 19, 2021
@mkarolin mkarolin force-pushed the maxk-cr93fu-disable-kReadLater branch from d087377 to 1b4e9cc Compare August 20, 2021 12:53
@mkarolin mkarolin requested a review from a team as a code owner August 20, 2021 12:53
@mkarolin mkarolin force-pushed the maxk-cr93fu-disable-kReadLater branch from 1b4e9cc to 90f0464 Compare August 20, 2021 14:51
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bsclifton bsclifton merged commit 310b606 into master Aug 24, 2021
@bsclifton bsclifton deleted the maxk-cr93fu-disable-kReadLater branch August 24, 2021 16:38
@bsclifton bsclifton added this to the 1.30.x - Nightly milestone Aug 24, 2021
mkarolin pushed a commit that referenced this pull request Aug 24, 2021
[cr93 followup] Disables kReadLater feature.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[cr93 followup] Turn off kReadLater feature by default
2 participants