Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes a crash on search in Tor profiles #8593

Merged
merged 1 commit into from
Apr 21, 2021
Merged

Conversation

SergeyZhukovsky
Copy link
Member

Resolves brave/brave-browser#15406

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@SergeyZhukovsky SergeyZhukovsky self-assigned this Apr 21, 2021
@SergeyZhukovsky
Copy link
Member Author

We decided to merge it without waiting for CI in DMs

@SergeyZhukovsky SergeyZhukovsky merged commit cfb3a19 into master Apr 21, 2021
@SergeyZhukovsky SergeyZhukovsky deleted the tor_search_crash branch April 21, 2021 18:58
@SergeyZhukovsky SergeyZhukovsky added this to the 1.25.x - Nightly milestone Apr 23, 2021
kylehickinson pushed a commit that referenced this pull request Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

crash when searching via Tor while Fallback has been enabled
2 participants