Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing gtest reporting. #8504

Closed
wants to merge 52 commits into from
Closed

Testing gtest reporting. #8504

wants to merge 52 commits into from

Conversation

wknapik
Copy link
Collaborator

@wknapik wknapik commented Apr 12, 2021

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@wknapik wknapik added CI/skip-android Do not run CI builds for Android CI/skip-windows CI/skip-ios Do not run CI builds for iOS labels Apr 12, 2021
@wknapik wknapik self-assigned this Apr 12, 2021
@wknapik wknapik requested a review from mihaiplesa as a code owner April 12, 2021 15:15
@wknapik wknapik added the CI/skip-macos-x64 Do not run CI builds for macOS x64 label Apr 12, 2021
@wknapik wknapik removed CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows labels Apr 14, 2021
@wknapik wknapik added CI/skip-ios Do not run CI builds for iOS CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Apr 20, 2021
@wknapik wknapik added CI/skip-ios Do not run CI builds for iOS CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 and removed CI/skip-ios Do not run CI builds for iOS CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Apr 21, 2021
@wknapik wknapik closed this Apr 21, 2021
@wknapik wknapik deleted the wknapik-gtest-improvements branch April 21, 2021 16:48
kylehickinson added a commit that referenced this pull request Jan 4, 2024
* Update BraveCore to v1.62.93

---------

Co-authored-by: Kyle Hickinson <git@kylehickinson.com>
kylehickinson pushed a commit that referenced this pull request Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant