Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only apply top level domain blocking in aggressive mode #8470

Merged
merged 1 commit into from
Apr 8, 2021

Conversation

pilgrim-brave
Copy link
Contributor

@pilgrim-brave pilgrim-brave commented Apr 7, 2021

Resolves brave/brave-browser#15095

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@pilgrim-brave pilgrim-brave force-pushed the mpilgrim_domain_block_aggressive branch from 35fc704 to 7ea5455 Compare April 7, 2021 19:58
@pilgrim-brave pilgrim-brave merged commit 869537b into master Apr 8, 2021
@pilgrim-brave pilgrim-brave deleted the mpilgrim_domain_block_aggressive branch April 8, 2021 00:21
@kjozwiak kjozwiak added this to the 1.25.x - Nightly milestone Apr 8, 2021
brave-builds pushed a commit that referenced this pull request Apr 8, 2021
@kjozwiak
Copy link
Member

Quickly went through this and it doesn't seem like it's working. Visiting either 1-1ads.com, actionsplash.com or pub.chez.com, will still load the interstitial page which indicates that top level domain blocking is still enabled. @pilgrim-brave is aware and is taking a look 👍

kylehickinson pushed a commit that referenced this pull request Jan 4, 2024
…status (#8470)

after NFT status chanegd, the re-computation needs to apply on only NFTs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only apply top level domain blocking in aggressive mode, by default
4 participants