Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

14942: Disable FLoC features and the provider service. #8468

Merged
merged 1 commit into from
Apr 8, 2021
Merged

14942: Disable FLoC features and the provider service. #8468

merged 1 commit into from
Apr 8, 2021

Conversation

iefremov
Copy link
Contributor

@iefremov iefremov commented Apr 7, 2021 •
edited
Loading

Resolves brave/brave-browser#14942

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Open brave://components and make sure that there is no Federated Learning of Cohorts component:
    Screenshot from 2021-04-09 17-14-41

  2. Open the devtools console, type document.interestCohort() and confirm that you get an error:
    Screenshot from 2021-04-09 17-09-09

@iefremov iefremov requested review from bridiver and a team as code owners April 7, 2021 15:20
@iefremov iefremov requested review from jumde and mkarolin April 7, 2021 15:23
@iefremov
Copy link
Contributor Author

iefremov commented Apr 7, 2021

As per the issue

FLoC client-side determinations of cohorts

The service is completely disabled

Any reporting of FLoC cohort determinations to Google (or otherwise) servers (i.e., the reporting used for k-anonymity cohort protections)

covered with kFlocIdComputedEventLogging

FLoC JS methods (i.e. document.interestCohort)

covered with kInterestCohortAPIOriginTrial

Any UI related to the FloC permission (i.e., interest-cohort)

not sure what it is yet

mkarolin
mkarolin approved these changes Apr 8, 2021
View reviewed changes
Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iefremov iefremov merged commit 676d293 into master Apr 8, 2021
@iefremov iefremov deleted the ie_disable_floc branch April 8, 2021 17:34
mariospr added a commit that referenced this pull request Apr 9, 2021
@mariospr
Drop use of federated_learning::kFlocIdSortingLshBasedComputation
765039c 
This definition has been dropped upstream as it's enabled by default
now, but even in that case that doesn't make a difference for Brave
as the FlocIdProviderImpl object is never created as per [1], so we
can simply drop these 2 lines.

[1] #8468

Chromium change:

https://chromium.googlesource.com/chromium/src.git/+/77462226d2aa2980c80e009ab7de098407af653d

commit 77462226d2aa2980c80e009ab7de098407af653d
Author: Yao Xiao <yaoxia@chromium.org>
Date:   Wed Mar 31 23:11:46 2021 +0000

    [floc] Use sorting-lsh by default. Remove base::Feature and clean up tests.

    Bug: 1190992
@kjozwiak kjozwiak added this to the 1.25.x - Nightly milestone Apr 9, 2021
@kjozwiak kjozwiak mentioned this pull request Apr 9, 2021
Closed
@kjozwiak
Copy link
Member

kjozwiak commented Apr 9, 2021

Adding this into the 1.25.x milestone as this landed in master.

@headllines headllines bot mentioned this pull request Apr 11, 2021
Open
@iefremov iefremov self-assigned this Apr 11, 2021
@notDavid notDavid mentioned this pull request Apr 11, 2021
Closed
@xueyuanl xueyuanl mentioned this pull request Apr 11, 2021
Open
@bbondy
Copy link
Member

bbondy commented Apr 12, 2021

Do we have a browsertest for document.interestCohort @iefremov ? If not can we add one?

@iefremov
Copy link
Contributor Author

@bbondy Sure, I'll add

mkarolin pushed a commit that referenced this pull request Apr 16, 2021
@mariospr @mkarolin
Drop use of federated_learning::kFlocIdSortingLshBasedComputation
4eade85 
This definition has been dropped upstream as it's enabled by default
now, but even in that case that doesn't make a difference for Brave
as the FlocIdProviderImpl object is never created as per [1], so we
can simply drop these 2 lines.

[1] #8468

Chromium change:

https://chromium.googlesource.com/chromium/src.git/+/77462226d2aa2980c80e009ab7de098407af653d

commit 77462226d2aa2980c80e009ab7de098407af653d
Author: Yao Xiao <yaoxia@chromium.org>
Date:   Wed Mar 31 23:11:46 2021 +0000

    [floc] Use sorting-lsh by default. Remove base::Feature and clean up tests.

    Bug: 1190992
@NilsIrl NilsIrl mentioned this pull request Apr 18, 2021
Open
mariospr added a commit that referenced this pull request Apr 20, 2021
@mariospr
Drop use of federated_learning::kFlocIdSortingLshBasedComputation
5d3e150 
This definition has been dropped upstream as it's enabled by default
now, but even in that case that doesn't make a difference for Brave
as the FlocIdProviderImpl object is never created as per [1], so we
can simply drop these 2 lines.

[1] #8468

Chromium change:

https://chromium.googlesource.com/chromium/src.git/+/77462226d2aa2980c80e009ab7de098407af653d

commit 77462226d2aa2980c80e009ab7de098407af653d
Author: Yao Xiao <yaoxia@chromium.org>
Date:   Wed Mar 31 23:11:46 2021 +0000

    [floc] Use sorting-lsh by default. Remove base::Feature and clean up tests.

    Bug: 1190992
mkarolin pushed a commit that referenced this pull request Apr 21, 2021
@mariospr @mkarolin
Drop use of federated_learning::kFlocIdSortingLshBasedComputation
250fe82 
This definition has been dropped upstream as it's enabled by default
now, but even in that case that doesn't make a difference for Brave
as the FlocIdProviderImpl object is never created as per [1], so we
can simply drop these 2 lines.

[1] #8468

Chromium change:

https://chromium.googlesource.com/chromium/src.git/+/77462226d2aa2980c80e009ab7de098407af653d

commit 77462226d2aa2980c80e009ab7de098407af653d
Author: Yao Xiao <yaoxia@chromium.org>
Date:   Wed Mar 31 23:11:46 2021 +0000

    [floc] Use sorting-lsh by default. Remove base::Feature and clean up tests.

    Bug: 1190992
mkarolin pushed a commit that referenced this pull request Apr 23, 2021
@mariospr @mkarolin
Drop use of federated_learning::kFlocIdSortingLshBasedComputation
ee56769 
This definition has been dropped upstream as it's enabled by default
now, but even in that case that doesn't make a difference for Brave
as the FlocIdProviderImpl object is never created as per [1], so we
can simply drop these 2 lines.

[1] #8468

Chromium change:

https://chromium.googlesource.com/chromium/src.git/+/77462226d2aa2980c80e009ab7de098407af653d

commit 77462226d2aa2980c80e009ab7de098407af653d
Author: Yao Xiao <yaoxia@chromium.org>
Date:   Wed Mar 31 23:11:46 2021 +0000

    [floc] Use sorting-lsh by default. Remove base::Feature and clean up tests.

    Bug: 1190992
mkarolin pushed a commit that referenced this pull request Apr 27, 2021
@mariospr @mkarolin
Drop use of federated_learning::kFlocIdSortingLshBasedComputation
1d9f15b 
This definition has been dropped upstream as it's enabled by default
now, but even in that case that doesn't make a difference for Brave
as the FlocIdProviderImpl object is never created as per [1], so we
can simply drop these 2 lines.

[1] #8468

Chromium change:

https://chromium.googlesource.com/chromium/src.git/+/77462226d2aa2980c80e009ab7de098407af653d

commit 77462226d2aa2980c80e009ab7de098407af653d
Author: Yao Xiao <yaoxia@chromium.org>
Date:   Wed Mar 31 23:11:46 2021 +0000

    [floc] Use sorting-lsh by default. Remove base::Feature and clean up tests.

    Bug: 1190992
@Peacock365 Peacock365 mentioned this pull request Apr 28, 2021
Closed
mkarolin pushed a commit that referenced this pull request Apr 30, 2021
@mariospr @mkarolin
Drop use of federated_learning::kFlocIdSortingLshBasedComputation
1a6e2a6 
This definition has been dropped upstream as it's enabled by default
now, but even in that case that doesn't make a difference for Brave
as the FlocIdProviderImpl object is never created as per [1], so we
can simply drop these 2 lines.

[1] #8468

Chromium change:

https://chromium.googlesource.com/chromium/src.git/+/77462226d2aa2980c80e009ab7de098407af653d

commit 77462226d2aa2980c80e009ab7de098407af653d
Author: Yao Xiao <yaoxia@chromium.org>
Date:   Wed Mar 31 23:11:46 2021 +0000

    [floc] Use sorting-lsh by default. Remove base::Feature and clean up tests.

    Bug: 1190992
mkarolin pushed a commit that referenced this pull request May 5, 2021
@mariospr @mkarolin
Drop use of federated_learning::kFlocIdSortingLshBasedComputation
ac3d649 
This definition has been dropped upstream as it's enabled by default
now, but even in that case that doesn't make a difference for Brave
as the FlocIdProviderImpl object is never created as per [1], so we
can simply drop these 2 lines.

[1] #8468

Chromium change:

https://chromium.googlesource.com/chromium/src.git/+/77462226d2aa2980c80e009ab7de098407af653d

commit 77462226d2aa2980c80e009ab7de098407af653d
Author: Yao Xiao <yaoxia@chromium.org>
Date:   Wed Mar 31 23:11:46 2021 +0000

    [floc] Use sorting-lsh by default. Remove base::Feature and clean up tests.

    Bug: 1190992
mariospr added a commit that referenced this pull request May 5, 2021
@mariospr
Drop use of federated_learning::kFlocIdSortingLshBasedComputation
aa3991f 
This definition has been dropped upstream as it's enabled by default
now, but even in that case that doesn't make a difference for Brave
as the FlocIdProviderImpl object is never created as per [1], so we
can simply drop these 2 lines.

[1] #8468

Chromium change:

https://chromium.googlesource.com/chromium/src.git/+/77462226d2aa2980c80e009ab7de098407af653d

commit 77462226d2aa2980c80e009ab7de098407af653d
Author: Yao Xiao <yaoxia@chromium.org>
Date:   Wed Mar 31 23:11:46 2021 +0000

    [floc] Use sorting-lsh by default. Remove base::Feature and clean up tests.

    Bug: 1190992
kylehickinson added a commit that referenced this pull request Jan 4, 2024
@kylehickinson
Ref #8417: Disable tint adjustment on secure state buttons (#8468)
39e8183 
This turns off the grayscale effect that is given to the button while controllers are presented on top of the browser
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bridiver bridiver bridiver approved these changes

@mkarolin mkarolin mkarolin approved these changes

@jumde jumde Awaiting requested review from jumde

Assignees

@iefremov iefremov

Labels
None yet
Projects
None yet
Milestone
1.25.x - Release
Development

Successfully merging this pull request may close these issues.

Disable FLoC in Brave
5 participants
@iefremov @kjozwiak @bbondy @bridiver @mkarolin