Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show a rewards notification when Uphold wallet linking limit is reached #8391

Merged
merged 1 commit into from
Mar 31, 2021

Conversation

zenparsing
Copy link
Collaborator

@zenparsing zenparsing commented Mar 30, 2021

Resolves brave/brave-browser#15028

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Scenario

  • Given that a user has reached their Uphold linking limit
  • When they connect their Uphold wallet to rewards
  • Then a notification will be displayed in the rewards panel informing them that they've reached their device linking limit.
  • And an entry will be recorded in the rewards database event log table.

Test Steps

  • Start the browser with a clean profile
  • Navigate to brave://rewards and click Verify Wallet
  • In the popup, click Login
  • Log in to Uphold with an account that has reached its device linking limit
  • Verify that a notification is displayed in the reward panel
  • Navigate to brave://rewards-internals and select the Event Log tab
  • Verify that a device_limit_reached entry appears in the event log

Screen Shot 2021-03-31 at 10 34 09 AM

@zenparsing zenparsing self-assigned this Mar 30, 2021
@zenparsing zenparsing requested a review from emerick March 30, 2021 19:54
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zenparsing
Copy link
Collaborator Author

@Miyayes Is the notification shown in the screenshot above acceptable? It reuses the same messaging and look that we are using for the bF implementation.

@Miyayes
Copy link

Miyayes commented Mar 31, 2021

@Miyayes Is the notification shown in the screenshot above acceptable? It reuses the same messaging and look that we are using for the bF implementation.

Are we able to add the "Learn more" link? Edit: Already exists in the form of the "Learn More" button in this case!

It deviates a bit from the recent design spec here, but I know it would take additional dev time to meet that design spec, and functionality is more important than form for this message at this time. We can update the styling as part of the other UI/UX refresh work :).

@zenparsing zenparsing merged commit 877b36f into master Mar 31, 2021
@zenparsing zenparsing deleted the ksmith-uphold-link-limit branch March 31, 2021 17:29
@zenparsing zenparsing added this to the 1.24.x - Nightly milestone Mar 31, 2021
kylehickinson pushed a commit that referenced this pull request Jan 4, 2024
… "reverse navigation" And Zoom In Zoom Out (#8391)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show a notification when user has exceeded wallet linking limit
3 participants